-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: render job title as commit message #32748
Conversation
To be honest, I do not think it is "correct". 🤣
In my mind, the brief ideas are either:
ps: you could use the mocked RepoActionView on devtest page to do test easily. |
Are you sure to use RenderIssueTitle? Because what we see on the title is commit message
Ok. I will remove issue context popup
Should i do it in this PR? Because as i see backend code more complex then to replace #number to link |
Update: maybe
It depends, either frontend or backend should work (only one is enough) But the question is whether it needs other render processors besides the link? |
Hmm sorry it seems that I misread, after reading the code again, |
@wxiaoguang done. is it ok. feel free to request anything else |
* giteaofficial/main: [skip ci] Updated licenses and gitignores Fix repo home row-right grow (go-gitea#32763) Refactor issue list (go-gitea#32755) Fix compare page bug view as anonymous (go-gitea#32754) Split issue/pull view router function as multiple smaller functions (go-gitea#32749) fix: render job title as commit message (go-gitea#32748) Fix typescript errors in Vue files, fix regression in "Recent Commits" chart (go-gitea#32649) Refactor LabelEdit (go-gitea#32752) [skip ci] Updated translations via Crowdin fix(project): add title to project view page (go-gitea#32747) [skip ci] Updated translations via Crowdin Fix case of .tsbuildinfo in .gitignore (go-gitea#32737) Support "merge upstream branch" (Sync fork) (go-gitea#32741) Update changelog to add missed changelog (go-gitea#32734) GitHub like repo home page (go-gitea#32213) Refactor markdown render (go-gitea#32736) Make wiki pages visit fast (go-gitea#32732) Refactor markdown render (go-gitea#32728) Refactor RepoActionView.vue, add `::group::` support (go-gitea#32713)
resolves #32724
i dont know if this is correct approach, waiting for suggestions