-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor LabelEdit #32752
Merged
Merged
Refactor LabelEdit #32752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
label
Dec 7, 2024
pull-request-size
bot
added
the
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
label
Dec 7, 2024
github-actions
bot
added
modifies/templates
This PR modifies the template files
modifies/frontend
labels
Dec 7, 2024
wxiaoguang
force-pushed
the
refactor-label-editor
branch
4 times, most recently
from
December 7, 2024 15:19
824b570
to
d3f6b84
Compare
wxiaoguang
added
the
type/refactoring
Existing code has been cleaned up. There should be no new functionality.
label
Dec 7, 2024
metiftikci
reviewed
Dec 7, 2024
wxiaoguang
force-pushed
the
refactor-label-editor
branch
from
December 7, 2024 16:28
d3f6b84
to
47a9665
Compare
silverwind
reviewed
Dec 7, 2024
silverwind
approved these changes
Dec 7, 2024
GiteaBot
added
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
and removed
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
labels
Dec 7, 2024
lunny
approved these changes
Dec 8, 2024
GiteaBot
added
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
and removed
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
labels
Dec 8, 2024
wxiaoguang
added
the
reviewed/wait-merge
This pull request is part of the merge queue. It will be merged soon.
label
Dec 8, 2024
GiteaBot
removed
the
reviewed/wait-merge
This pull request is part of the merge queue. It will be merged soon.
label
Dec 8, 2024
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Dec 9, 2024
* giteaofficial/main: [skip ci] Updated licenses and gitignores Fix repo home row-right grow (go-gitea#32763) Refactor issue list (go-gitea#32755) Fix compare page bug view as anonymous (go-gitea#32754) Split issue/pull view router function as multiple smaller functions (go-gitea#32749) fix: render job title as commit message (go-gitea#32748) Fix typescript errors in Vue files, fix regression in "Recent Commits" chart (go-gitea#32649) Refactor LabelEdit (go-gitea#32752) [skip ci] Updated translations via Crowdin fix(project): add title to project view page (go-gitea#32747) [skip ci] Updated translations via Crowdin Fix case of .tsbuildinfo in .gitignore (go-gitea#32737) Support "merge upstream branch" (Sync fork) (go-gitea#32741) Update changelog to add missed changelog (go-gitea#32734) GitHub like repo home page (go-gitea#32213) Refactor markdown render (go-gitea#32736) Make wiki pages visit fast (go-gitea#32732) Refactor markdown render (go-gitea#32728) Refactor RepoActionView.vue, add `::group::` support (go-gitea#32713)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
modifies/frontend
modifies/templates
This PR modifies the template files
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
type/refactoring
Existing code has been cleaned up. There should be no new functionality.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And fix a regression: #30053 (comment)
Major changes: