Git-Trees API. #4185

Kasi-R · 2018-06-08T16:30:05Z

Started on Git-Trees API. Added methods for getting a tree and getting a tree recursively as per https://developer.github.com/v3/git/trees/

Creating a tree not done.

routers/api/v1/repo/tree.go

routers/api/v1/api.go

Kasi-R · 2018-06-13T10:15:09Z

Done. I used the types from go-gitea/go-sdk#109 however, i can change it to the types used in go-gitea/go-sdk#94 if required.

techknowlogick · 2018-11-24T03:16:49Z

@Kasi-R would it be possible to use other PR in SDK? I think it would be best to merge in functionality then another PR for enhancement.

techknowlogick · 2018-11-24T03:17:11Z

@lafriks please update review. Can you also review go-gitea/go-sdk#94?

lafriks · 2018-11-24T11:04:53Z

routers/api/v1/api.go

 			m.Group("/:username/:reponame", func() {
 				m.Combo("").Get(repo.Get).Delete(reqToken(), repo.Delete)
+				m.Group("/trees", func() {


we should probably use github compatible route (/git/trees)

lafriks · 2018-11-24T11:05:15Z

@techknowlogick done

necaris

Just a couple of small requests for better explanation of where some constants are coming from -- otherwise this looks good, very straightforward -- certainly simpler than my attempt #1978 !

necaris · 2018-11-25T06:42:10Z

routers/api/v1/repo/tree.go

+		return tree
+	}
+	RepoIDLen := len(RepoID)
+	BlobURL := make([]byte, RepoIDLen + 47)


@Kasi-R could you please add a comment or variable describing where the magic number 47 comes from?

necaris · 2018-11-25T06:42:27Z

routers/api/v1/repo/tree.go

+	BlobURL := make([]byte, RepoIDLen + 47)
+	copy(BlobURL[:], RepoID)
+	copy(BlobURL[RepoIDLen:], "/blobs/")
+	TreeURL := make([]byte, RepoIDLen + 47)


See above -- same here please.

necaris · 2018-11-25T06:46:49Z

routers/api/v1/repo/tree.go

+	TreeURL := make([]byte, RepoIDLen + 47)
+	copy(TreeURL[:], RepoID)
+	copy(TreeURL[RepoIDLen:], "/trees/")
+	CopyPos := len(TreeURL) - 40


Similar request here -- where is the 40 coming from?

…4722) Signed-off-by: Andrew Phillips <theasp@gmail.com>

) Signed-off-by: Tosone <i@tosiney.com>

* Make sure author cannot reject/approve their own PR * Disable buttons in templates too * Remove unneccessary if check since the switch below catches it * Fix IsOwner check * Update template and remove new template variable * Add alert template and redirect to diff page on review failure * Redirect to files diff as a little update to #4632

…ttached to the team (#4719)

* Make sure to reset commit count in the cache on mirror syncing * reset count of commits in all branches

* Update dep github.com/markbates/goth * Update dep github.com/blevesearch/bleve * Update dep golang.org/x/oauth2 * Fix github.com/blevesearch/bleve to c74e08f039e56cef576e4336382b2a2d12d9e026 * Update dep golang.org/x/oauth2

* implement email domain whitelist

#5317)

Signed-off-by: Lucien Kerl <lucien.kerl@wuerth-it.com>

To support go-gitea/infrastructure#39

* Remove field from migration to support upgrades from older version That will ensure the field does not get queried in the Select if it does not exist yet: ``` [I] [SQL] SELECT "id", "repo_id", "index", "poster_id", "name", "content", "milestone_id", "priority", "assignee_id", "is_closed", "is_pull", "num_comments", "ref", "deadline_unix", "created_unix", "updated_unix [...itea/routers/init.go:60 GlobalInit()] [E] Failed to initialize ORM engine: migrate: do migrate: pq: column "ref" does not exist ``` see #5318 * Skip remove stale watcher migration if not required Otherwise the migration will fail if executed from a older database version without multiple IssueWatch feature. ``` 2018/11/11 23:51:14 [I] [SQL] SELECT DISTINCT "issue_watch"."user_id", "issue"."repo_id" FROM "issue_watch" INNER JOIN issue ON issue_watch.issue_id = issue.id WHERE (issue_watch.is_watching = $1) LIMIT 50 []int [...itea/routers/init.go:60 GlobalInit()] [E] Failed to initialize ORM engine: migrate: do migrate: pq: relation "issue_watch" does not exist ``` see #5318

* Add raw blob endpoint This should make it possible to download raw blobs directly from /:repo/:username/raw/blob/:sha1 URLs. * fix: Make it work * As an SHA-ID is no path getRefNameFromPath can't be used to verify file specifying parameter * added relevant change in go-gitea/git #132 Signed-off-by: Berengar W. Lehr <Berengar.Lehr@kompetenztest.de> * Update Gopkg.lock Can't update all vendors due to errors Signed-off-by: Berengar W. Lehr <Berengar.Lehr@kompetenztest.de> * style: Add Gitea copyright header * feat: Added integration test for /repo/u/r/raw/blob * fix: correct year in copyright header

Doc: https://github.com/go-gitea/gitea/blob/b97af15de67b04fd259bd70a4abbc873f12e9491/docs/content/doc/advanced/config-cheat-sheet.en-us.md#service-service

* add api for user to create org * remove unused blank line on the swagger file end * fix create and add test * fix tests * fix routes of create org API * fix bug * add copyright heads

* #3758: [doc] file rendering through external binaries * fix subsections markup * include proposed changes from PR review

#3829) (#5383) Signed-off-by: Daniel Balko <inxonic+github@gmail.com>

…ount via cli (#5391) * don't force a password change for the admin user * don't totally dicard -must-change-password flag if creating the first (admin) user via the cli. Use flag if present but make sure to default to not forcing a password update

@sapk

* Notes on upgrading docker installation Basis from [gogs/gogs](https://github.com/gogs/gogs/blob/master/docker/README.md) * Feedback from @sapk to use docker-compose only

techknowlogick added the modifies/api This PR adds API routes or modifies them label Jun 8, 2018

Kasi-R mentioned this pull request Jun 10, 2018

Added Tree API functionality go-gitea/go-sdk#109

Closed

lafriks requested changes Jun 13, 2018

View reviewed changes

routers/api/v1/repo/tree.go Outdated Show resolved Hide resolved

routers/api/v1/repo/tree.go Outdated Show resolved Hide resolved

routers/api/v1/api.go Outdated Show resolved Hide resolved

bkcsoft added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 13, 2018

HoffmannP mentioned this pull request Oct 25, 2018

API should list commits #5181

Closed

HoffmannP mentioned this pull request Nov 23, 2018

API: file listing / tree access #1978

Closed

lafriks reviewed Nov 24, 2018

View reviewed changes

lunny mentioned this pull request Nov 25, 2018

[WIP] feature: list files in tree #2749

Closed

necaris approved these changes Nov 25, 2018

View reviewed changes

SagePtr and others added 17 commits November 26, 2018 06:42

Fix incorrect caption of webhook setting (#4701) (#4717)

7c45a55

[skip ci] Updated translations via Crowdin

48338e1

Remove UsePrivilegeSeparation from the Docker sshd_config, see #2876 (#…

a59c455

…4722) Signed-off-by: Andrew Phillips <theasp@gmail.com>

[skip ci] Updated translations via Crowdin

bf6c63d

Fix failure on creating pull request with assignees (#4419) (#4583)

7b4bcc4

[skip ci] Updated translations via Crowdin

99f0e54

Add whitespace between chinese characters and english characters. (#4731

ed04816

) Signed-off-by: Tosone <i@tosiney.com>

Display error when adding a user to a team twice (#4746)

46905a3

allow WIP marker to contains < or > (#4709)

45a60f1

add letsencrypt to Gitea (#4189)

37c34e0

[skip ci] Updated translations via Crowdin

7a950a2

Fixed bug where team with admin privelege type doesn't get any unit a…

6598e98

…ttached to the team (#4719)

Make sure to reset commit count in the cache on mirror syncing (#4720)

f658384

* Make sure to reset commit count in the cache on mirror syncing * reset count of commits in all branches

[skip ci] Updated translations via Crowdin

b92db71

Add myself to maintainers (#4777)

59b1daa

[skip ci] Updated translations via Crowdin

5b9c8fe

GiteaBot and others added 27 commits November 26, 2018 06:42

[skip ci] Updated translations via Crowdin

0eac73a

Fix create team, update team missing units (#5188)

b5c770f

Remove x/net/context vendor by using std package (#5202)

0bd5f6f

* Update dep github.com/markbates/goth * Update dep github.com/blevesearch/bleve * Update dep golang.org/x/oauth2 * Fix github.com/blevesearch/bleve to c74e08f039e56cef576e4336382b2a2d12d9e026 * Update dep golang.org/x/oauth2

Block registration based on email domain (#5157)

dd76689

* implement email domain whitelist

[skip ci] Updated translations via Crowdin

dc076df

Implement pasting image from clipboard for browsers that supports that (

7906976

#5317)

added the ability to set labels on the "edit pull request" api (#5347)

74f03d3

Signed-off-by: Lucien Kerl <lucien.kerl@wuerth-it.com>

[skip ci] Updated translations via Crowdin

89a1eb2

Set ACL on uploads (#5344)

cb37bc1

To support go-gitea/infrastructure#39

[skip ci] Updated translations via Crowdin

fd9ea48

app.ini.sample: add ENABLE_USER_HEATMAP default config (#5362)

a74bb76

Doc: https://github.com/go-gitea/gitea/blob/b97af15de67b04fd259bd70a4abbc873f12e9491/docs/content/doc/advanced/config-cheat-sheet.en-us.md#service-service

dont' send assign webhooks when creating issue (#5365)

15e42cf

add api for user to create org (#5268)

5563133

* add api for user to create org * remove unused blank line on the swagger file end * fix create and add test * fix tests * fix routes of create org API * fix bug * add copyright heads

support envs on external render commands (#5278)

d805745

Show review summary in pull requests (#5132)

3af4c56

Backport 1.6.0 changelog to master (#5384)

96e797e

[skip ci] Updated translations via Crowdin

092efad

[website] file rendering through external binaries (#5387)

95a419b

* #3758: [doc] file rendering through external binaries * fix subsections markup * include proposed changes from PR review

API: '/orgs/:org/repos': return private repos with read access (#5310) (

99fa5ee

#3829) (#5383) Signed-off-by: Daniel Balko <inxonic+github@gmail.com>

Fix typos in configuration (#5398)

a7b3e41

Fix dependent issue searching when gitea is run in subpath (#5392)

8c7ad40

Notes on upgrading docker installation (#5395)

af99357

* Notes on upgrading docker installation Basis from [gogs/gogs](https://github.com/gogs/gogs/blob/master/docker/README.md) * Feedback from @sapk to use docker-compose only

changed route from /trees to /git/trees. added additional comments.

5355736

Merge branch 'master' of https://github.com/Kasi-R/gitea

2a959b4

Kasi-R closed this Nov 26, 2018

Kasi-R mentioned this pull request Nov 26, 2018

Git-Trees API #5403

Merged

go-gitea locked and limited conversation to collaborators Nov 24, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Git-Trees API. #4185

Git-Trees API. #4185

Kasi-R commented Jun 8, 2018

Kasi-R commented Jun 13, 2018

techknowlogick commented Nov 24, 2018

techknowlogick commented Nov 24, 2018 •

edited by lafriks

Loading

lafriks Nov 24, 2018

lafriks commented Nov 24, 2018

necaris left a comment

necaris Nov 25, 2018

necaris Nov 25, 2018

necaris Nov 25, 2018

Git-Trees API. #4185

Git-Trees API. #4185

Conversation

Kasi-R commented Jun 8, 2018

Kasi-R commented Jun 13, 2018

techknowlogick commented Nov 24, 2018

techknowlogick commented Nov 24, 2018 • edited by lafriks Loading

lafriks Nov 24, 2018

Choose a reason for hiding this comment

lafriks commented Nov 24, 2018

necaris left a comment

Choose a reason for hiding this comment

necaris Nov 25, 2018

Choose a reason for hiding this comment

necaris Nov 25, 2018

Choose a reason for hiding this comment

necaris Nov 25, 2018

Choose a reason for hiding this comment

techknowlogick commented Nov 24, 2018 •

edited by lafriks

Loading