Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call error messages, gdext rename #167

Merged
merged 3 commits into from
Mar 10, 2023
Merged

Call error messages, gdext rename #167

merged 3 commits into from
Mar 10, 2023

Conversation

Bromeon
Copy link
Member

@Bromeon Bromeon commented Mar 10, 2023

Improves the diagnostics when calling into Godot APIs.

Also updates documentation to reflect the rename to gdext (from whatever the name was before 😀).

Makes Debug impl for GodotString, StringName and NodePath more consistent:

  • "string"
  • &"name"
  • ^"path"

@Bromeon Bromeon added quality-of-life No new functionality, but improves ergonomics/internals c: tooling CI, automation, tools c: engine Godot classes (nodes, resources, ...) labels Mar 10, 2023
@Bromeon
Copy link
Member Author

Bromeon commented Mar 10, 2023

bors r+

bors bot added a commit that referenced this pull request Mar 10, 2023
167: Call error messages, `gdext` rename r=Bromeon a=Bromeon

Improves the diagnostics when calling into Godot APIs.

Also updates documentation to reflect the rename to `gdext` (from whatever the name was before 😀).

Makes `Debug` impl for `GodotString`, `StringName` and `NodePath` more consistent:
* `"string"`
* `&"name"`
* `^"path"`

Co-authored-by: Jan Haller <bromeon@gmail.com>
@Bromeon Bromeon force-pushed the feature/call-errors branch from a9c3ee5 to 207c4e7 Compare March 10, 2023 21:11
@bors
Copy link
Contributor

bors bot commented Mar 10, 2023

Canceled.

@Bromeon
Copy link
Member Author

Bromeon commented Mar 10, 2023

bors r+

@bors
Copy link
Contributor

bors bot commented Mar 10, 2023

Build succeeded:

@bors bors bot merged commit 54cb201 into master Mar 10, 2023
@bors bors bot deleted the feature/call-errors branch March 10, 2023 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: engine Godot classes (nodes, resources, ...) c: tooling CI, automation, tools quality-of-life No new functionality, but improves ergonomics/internals
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant