Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Streamline modules - part II: godot::extra, notifications #732

Merged
merged 5 commits into from
May 26, 2024

Conversation

Bromeon
Copy link
Member

@Bromeon Bromeon commented May 26, 2024

Sequel of #729.

  • Adds godot::extras module with all the higher-level engine functionality, such as ScriptInstance and GFile
  • Changes notification constants to SHOUT_CASE, consistent with all other enums/constants
  • Simplify NODE_RECACHE_REQUESTED workaround, also on older API levels (see Godot issue)

@Bromeon Bromeon added quality-of-life No new functionality, but improves ergonomics/internals c: engine Godot classes (nodes, resources, ...) labels May 26, 2024
@Bromeon Bromeon force-pushed the qol/streamlined-modules-2 branch from ab9563e to 74f6092 Compare May 26, 2024 21:48
@GodotRust
Copy link

API docs are being generated and will be shortly available at: https://godot-rust.github.io/docs/gdext/pr-732

@Bromeon Bromeon force-pushed the qol/streamlined-modules-2 branch from 74f6092 to 685e0a2 Compare May 26, 2024 21:50
@Bromeon Bromeon enabled auto-merge May 26, 2024 21:52
@Bromeon Bromeon added this pull request to the merge queue May 26, 2024
@Bromeon
Copy link
Member Author

Bromeon commented May 26, 2024

I'm merging those refactorings quickly because they have lots of merge conflict potential. The module structure is not yet final, so maybe wait with upgrading until the dust settles 🙂

Merged via the queue into master with commit 1e9ea80 May 26, 2024
15 checks passed
@Bromeon Bromeon deleted the qol/streamlined-modules-2 branch May 26, 2024 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: engine Godot classes (nodes, resources, ...) quality-of-life No new functionality, but improves ergonomics/internals
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants