Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Variant::object_id() #914

Merged
merged 2 commits into from
Nov 23, 2024
Merged

Add Variant::object_id() #914

merged 2 commits into from
Nov 23, 2024

Conversation

Bromeon
Copy link
Member

@Bromeon Bromeon commented Oct 9, 2024

Follow upstream godotengine/godot#97119.

Also improved doc + test coverage for the existing Callable::object_id() + Signal::object_id().

@Bromeon Bromeon added feature Adds functionality to the library c: core Core components labels Oct 9, 2024
@Bromeon Bromeon force-pushed the feature/variant-object-id branch from adfe6eb to 9a0d8ba Compare October 9, 2024 11:49
@GodotRust
Copy link

API docs are being generated and will be shortly available at: https://godot-rust.github.io/docs/gdext/pr-914

@Bromeon
Copy link
Member Author

Bromeon commented Nov 23, 2024

I kept this open, as the #[cfg(since_api = "4.4")] is inactive for the current doc tasks, because those run on default api-* feature (currently 4.3). We would need api-custom feature + nightly Godot to display latest symbols, but that's a bigger change. I made a corresponding comment in the website repo: godot-rust/godot-rust.github.io@2a83b54

So I'll merge this, but it won't be available in online docs until 4.4 is released. People who want 100% accurate docs with 4.4-dev features can build docs locally using api-custom.

@Bromeon Bromeon added this pull request to the merge queue Nov 23, 2024
Merged via the queue into master with commit 8a62088 Nov 23, 2024
15 checks passed
@Bromeon Bromeon deleted the feature/variant-object-id branch November 23, 2024 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: core Core components feature Adds functionality to the library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants