Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix github action paths / parameters #47

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

Ivorforce
Copy link
Contributor

@Ivorforce Ivorforce commented Sep 20, 2024

This does several things:

  • It actually publishes / fixes the parameters, intended for different folder setups of the project.
  • godot-cpp is actually built now, as intended by the action author.
    • I'm not sure if we even need to, given that the latter command builds it fine. But that's for another PR to decide.
  • It fixes scons caches, making builds a lot faster (I tested this; repeated builds now fly by very fast).
  • It fixes a build error on windows when compiling with doc data.

@paddy-exe paddy-exe requested a review from akien-mga September 25, 2024 15:15
@paddy-exe paddy-exe requested a review from adamscott October 25, 2024 19:40
Copy link
Member

@adamscott adamscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems ok. I would though rename everything to be consistent, i.e. using directory instead of folder.

@Ivorforce Ivorforce force-pushed the Ivorforce-patch-action branch from 0aad514 to 4fb3c7a Compare October 28, 2024 18:00
@Ivorforce
Copy link
Contributor Author

Ok, I renamed all the parameters to be consistent in naming scheme (except scons-cache, which corresponds to a parameter of the same name from godot itself).

@Ivorforce Ivorforce requested a review from adamscott October 28, 2024 18:01
@paddy-exe paddy-exe added the bug Something isn't working label Oct 28, 2024
@Ivorforce Ivorforce force-pushed the Ivorforce-patch-action branch from 021e286 to b4ea2d3 Compare October 28, 2024 23:11
@paddy-exe paddy-exe merged commit d100b72 into godotengine:main Nov 5, 2024
@paddy-exe
Copy link
Collaborator

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants