Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All popups close when the main window is hidden, minimized, moved or resized #37732

Closed
Tracked by #37734
Zylann opened this issue Apr 9, 2020 · 2 comments · Fixed by #39993
Closed
Tracked by #37734

All popups close when the main window is hidden, minimized, moved or resized #37732

Zylann opened this issue Apr 9, 2020 · 2 comments · Fixed by #39993

Comments

@Zylann
Copy link
Contributor

Zylann commented Apr 9, 2020

Godot 4 b3310a0
Windows 10 64 bits

In the project manager, when a popup is opened (to create a project for example), focusing another app or minimizing Godot and then focusing it again will restore popups as they were, but they will immediately all close, instead of being focused back.
It also happens when interacting with the decoration of the main window, and it's quite annoying to have such popups behaving in such a "volatile" way (that no other native app does).

  1. Open Project Manager
  2. Choose New Project
  3. Click on another app (or interact with Godot's main window decoration)
  4. Click back onto Godot: the New Project popup closes.

Also reproduces with editor popups, such as project settings.

This did not happen in Godot 3.2.1.

@giarve
Copy link
Contributor

giarve commented Apr 30, 2020

I think this is exactly the same as #37710. Dropdowns are implemented as windows and when focus is lost they're closed. If somebody decides to take a look notice that it may be the same issue about loosing focus (main window is hidden, minimized, moved or resized requires changing focus).

@Anutrix
Copy link
Contributor

Anutrix commented May 29, 2020

The issue leads to this:

void AcceptDialog::_parent_focused() {
_cancel_pressed();
}

The focus_entered signal as well as AcceptDialog::_notification seem to be problematic.

reduz added a commit to reduz/godot that referenced this issue Jun 30, 2020
Also fix on set_visible, not creating exclusive children as it should.
akien-mga added a commit that referenced this issue Jun 30, 2020
Make dialogs exclusive by default, fixes #37732
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants