Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash on trimesh_create #34794

Merged
merged 1 commit into from
Jan 3, 2020

Conversation

clayjohn
Copy link
Member

@clayjohn clayjohn commented Jan 3, 2020

Fixes: #33197

As discussed in, #29751, surface->data needs to always be available.

This makes surface->data available as it was before 3f681b0

@clayjohn clayjohn added this to the 3.2 milestone Jan 3, 2020
@clayjohn clayjohn requested a review from reduz as a code owner January 3, 2020 21:42
@akien-mga akien-mga merged commit 94658de into godotengine:master Jan 3, 2020
@akien-mga
Copy link
Member

Thanks!

@lawnjelly
Copy link
Member

Just to check, 3f681b0 also introduced some error messages e.g.

#ifndef TOOLS_ENABLED
	ERR_PRINT("OpenGL ES 2.0 does not allow retrieving mesh array data");
#endif

Are any of these now redundant now the data has been retained?

@issork
Copy link
Contributor

issork commented Jan 26, 2020

Just to check, 3f681b0 also introduced some error messages e.g.

#ifndef TOOLS_ENABLED
	ERR_PRINT("OpenGL ES 2.0 does not allow retrieving mesh array data");
#endif

Are any of these now redundant now the data has been retained?

That seems to be the case, my exported GLES2 Project uses both MeshDataTool and create_trimesh_collision(), both spam the console of the exported project with that error message, despite working properly now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Project on Android and in Web crash when using create_trimesh_shape on GLES2
4 participants