Added support for allowing apps to push to protected branches #1283
Conversation
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #1283 +/- ##
==========================================
- Coverage 73.4% 73.33% -0.08%
==========================================
Files 86 86
Lines 6043 6087 +44
==========================================
+ Hits 4436 4464 +28
- Misses 837 845 +8
- Partials 770 778 +8
Continue to review full report at Codecov.
|
|
@gmlewis Can you please review it? |
There was a problem hiding this comment.
Thank you, @shibasisp! This is looking good.
Please address the comments. Additionally, for this to fully resolve #1275, one of the existing PUT endpoints needs to have a new restrictions field to be added to the request. If you could address that as well, that would be great.
Thanks again!
|
@gmlewis thanks for the review. I have modified the codes accordingly.
I think, I have already modified the already existing PUT endpoint( |
There was a problem hiding this comment.
Ah, you are exactly right. Thank you, @shibasisp!
LGTM.
Awaiting second LGTM before merging.
|
@gauntface can you please review it? |
|
Thank you, @wesleimp ! |
I got following error. json: cannot unmarshal string into Go struct field App.app.events of type github.Event It's regression from google#1283 and event type should be actually string [1][2]. [1]: https://developer.github.com/v3/apps/#get-a-single-github-app [2]: https://developer.github.com/v3/repos/branches/#list-apps-with-access-to-protected-branch
fixes #1275