Gposton/branch protection apps #297
Conversation
ghost
added
the
|
It would be so awesome to have this 😊 Hence, out of curiosity, any news on this? |
|
Still waiting on the upstream change. |
|
Thanks for the fast reply 😊 |
|
Upstream change just merged: google/go-github#1283 |
gposton-goodmoney
force-pushed
the
gposton/branch_protection_apps
branch
from
5f1e1bd to
4ce4a7e
Compare
|
@goloroden @paultyng I just rebased this and it should be good2go! See comment here: https://github.com/terraform-providers/terraform-provider-github/pull/296#issuecomment-578916134 |
|
@paultyng how do I vendor in new changes from google/go-github#1283? |
gposton
force-pushed
the
gposton/branch_protection_apps
branch
from
4ce4a7e to
23e31ed
Compare
|
@paultyng @goloroden @umpox Upstream change was vendored in with this commit: hashicorp@c533ed9. I've rebased this branch and it should be good to go now! |
|
Thanks for the ping 😄 This is missing a documentation update to https://github.com/terraform-providers/terraform-provider-github/blob/master/website/docs/r/branch_protection.html.markdown. I'll run the acceptance tests here to confirm no regressions and plan to ship this once the docs are updated. |
|
@gposton thanks for getting those updated. The acceptance test that this case falls under has been failing regularly, but has become more stable from the work over in https://github.com/terraform-providers/terraform-provider-github/pull/372. I'd like to focus on shipping the test fix over there before circling back to this one. Ideally, this ships end of week after the related acceptance tests pass. Thanks for the extra patience 😄 |
|
@jcudit - If the test is flakey, and unrelated to the code in this PR, why make this PR wait? It looks like the last Travis build passed. |
|
Nice! |
…ction_apps Gposton/branch protection apps
Adds support for assigning 'apps' in branch protection rules.
Note that this requires changes from upstream vendor (google/go-github) to be vendor'd in.
See upstream vendor PR here: google/go-github#1337
Note: From the comments in the above PR, it looks like this PR is the one that's actually going to land (same functionality) google/go-github#1283