Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for adding apps to branch protection #1337

Closed

Conversation

gposton
Copy link

@gposton gposton commented Nov 21, 2019

This PR adds support for adding apps to branch protection rules.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@gposton
Copy link
Author

gposton commented Nov 21, 2019

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes Indication that the PR author has signed a Google Contributor License Agreement. and removed cla: no labels Nov 21, 2019
@gmlewis
Copy link
Collaborator

gmlewis commented Nov 21, 2019

Is this related to #1275 and #1283 ?
If so, then I think this issue is already assigned and someone is working on it, and we need to close this.

In general, in this repo we try to make it clear who is working on what issues so that work is not duplicated. As a result, PRs should in general be associated with open issues.

Thanks for your understanding, @gposton.

@gposton
Copy link
Author

gposton commented Nov 21, 2019

Yes, this addresses those issues as well.

@gmlewis
Copy link
Collaborator

gmlewis commented Feb 22, 2020

Closing this issue as it was resolved in #1283.

@gmlewis gmlewis closed this Feb 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indication that the PR author has signed a Google Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants