-
Notifications
You must be signed in to change notification settings - Fork 274
feat: Make website no longer depend on Bug entities #4469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
/gemini review |
| sev = '' | ||
| if 'severity' in record: | ||
| sev = 'severity' | ||
| elif 'severities' in record: | ||
| sev = 'severities' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah - I use this function both for the vulnerability page (osv vulns have the severity field) and the list page (ListedVulnerabilities use severities)
Make use of the
ListedVulnerabilitydatastore entity for the/listpage, and the GCS bucket for the vulnerability page, instead of the hefty, deprecatedBugentity for both.Unfortunately, the
ListedVulnerabilitydoes not quite have enough information as-is to 100% match the current behaviour, and a couple of things will be regressed:is_fixedfield on theListedVulnerability(and computing it currently would require another query to the full vulnerability, which I'm trying to avoid on the list page). I think we could update theListedVulnerabilityto have a list of fixed ecosystems to re-enable this, but I'd want to do that in a followup PR.