fix(frontend): fix ecosystem filtering for versioned ecosystem variants #3813
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
another-rex
approved these changes
Aug 18, 2025
Contributor
|
/gcbrun |
6 tasks
Contributor
|
Hmm, this issue still seems to be showing up for GIT ecosystems. E.g. https://test.osv.dev/list?q=CVE-2025-55285&ecosystem=GIT |
Contributor
|
The git one is a bit weird, you need to add a special case for it, maybe just try to match all ecosystems if the input ecosystem is GIT. |
Contributor
Author
Just noticed that too - this stems from Git ecosystems missing a |
michaelkedar
added a commit
that referenced
this pull request
Dec 16, 2025
Make use of the `ListedVulnerability` datastore entity for the `/list` page, and the GCS bucket for the vulnerability page, instead of the hefty, deprecated `Bug` entity for both. Unfortunately, the `ListedVulnerability` does not quite have enough information as-is to 100% match the current behaviour, and a couple of things will be regressed: - #3356 because we don't have alias/related/upstream information on the new entity. I've made exact ID matches sort first, which should be okay temporarily. - #3812 / #3813 since there is no per-ecosystem `is_fixed` field on the `ListedVulnerability` (and computing it currently would require another query to the full vulnerability, which I'm trying to avoid on the list page). I think we could update the `ListedVulnerability` to have a list of fixed ecosystems to re-enable this, but I'd want to do that in a followup PR. - Also, records that have no affected packages (but are not withdrawn) will now show up on the search page. IDK if that's preferable or not.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes ecosystem filtering to correctly match versioned ecosystem variants (e.g., filtering by "Alpaquita" now matches "Alpaquita:23", "Alpaquita:stream").
Closes #3812