fix: revert reverting [Many APIs] Update WORKSPACE files for rules_gapic, gax_java, generator_java versions #8340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit c9bb4a9.
gcf-owl-bot
bot
removed
the
owlbot:run
suztomo
changed the title
|
GitHub said OwlBot PostProcessor failed
But the build is still running. |
|
It died with 80 minutes timeout
It was very close. |
docker run --rm -v $(pwd):/workspace -w /workspace --user $(id -u):$(id -g) gcr.io/cloud-devrel-public-resources/owlbot-java
gcf-owl-bot
bot
removed
the
owlbot:run
|
I ran owlbot-java manually: It seems working. |
gcf-owl-bot
bot
removed
the
owlbot:run
|
I think it's waiting for a new shared dependencies BOM.
|
|
The google-data-analytics module is not referencing java-analytics module's pom.xml in this repository, because the version is different. It now references the artifact in Maven Central, which references an old GAX version. |
suztomo
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
The Xxe.java does not exist in the split repo yet. https://github.com/googleapis/java-websecurityscanner/pull/741/files#diff-3d6f33fcbec6e90a00dbdb58f08e676785b42d9b946fc9d08016a0c8d2e31e21 (not merged yet; 2 CL changes) is adding the class to the repository.
|
suztomo
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
|
All checks green. |
meltsufin
approved these changes
Sep 19, 2022
1 task
Closed
This was referenced Sep 27, 2022
suztomo
added a commit
to suztomo/google-cloud-java
that referenced
this pull request
Oct 4, 2022
…pic, gax_java, generator_java versions (googleapis#8340) * Revert "fix: owl-bot-staging should not be commited (googleapis#8337)" This reverts commit c9bb4a9. * owlbot-java postprocessor docker run --rm -v $(pwd):/workspace -w /workspace --user $(id -u):$(id -g) gcr.io/cloud-devrel-public-resources/owlbot-java * manual fix * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * use shared dep bom without property Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #8337, which reverted #8305. 8305 was merged without OwlBot Java Postprocessor (owl-bot-staging directory). We should merged the change after processing OwlBot Java PostProcessor.
The idea is that OwlBot Java PostProcessor should process the content of owl-bot-staging if we wait. No need to have OwlBot service to re-create the pull request.