Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add websecurityscanner changes #8471

Closed
wants to merge 2 commits into from
Closed

chore: Add websecurityscanner changes #8471

wants to merge 2 commits into from

Conversation

lqiu96
Copy link
Contributor

@lqiu96 lqiu96 commented Sep 27, 2022

The *.java changes are found from #8448
The *.proto changes are found from #8449

Looks to have been reverted as part of #8340

@lqiu96 lqiu96 added the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 27, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 27, 2022
@snippet-bot
Copy link

snippet-bot bot commented Sep 27, 2022

Here is the summary of possible violations 😱

There is a possible violation for not having product prefix.

The end of the violation section. All the stuff below is FYI purposes only.


Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@lqiu96
Copy link
Contributor Author

lqiu96 commented Sep 27, 2022

Not sure why owlbot is deleting this from README.md

<dependencyManagement>
  <dependencies>
    <dependency>
      <groupId>com.google.cloud</groupId>
      <artifactId>libraries-bom</artifactId>
      <version>26.1.0</version>
      <type>pom</type>
      <scope>import</scope>
    </dependency>
  </dependencies>
</dependencyManagement>

<dependencies>
  <dependency>
    <groupId>com.google.cloud</groupId>
    <artifactId>google-cloud-websecurityscanner</artifactId>
  </dependency>

If you are using Maven without BOM, add this to your dependencies:

Is this intended behavior for owlbot?

It's also adding in the samples/ dir again

Seems to be the behavior from the previous PRs

@lqiu96
Copy link
Contributor Author

lqiu96 commented Oct 7, 2022

Closing as it is not an issue any longer: #8448

@lqiu96 lqiu96 closed this Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant