Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Add java-vision diff between monorepo and split-repo #8472

Closed
wants to merge 2 commits into from
Closed

chore: Add java-vision diff between monorepo and split-repo #8472

wants to merge 2 commits into from

Conversation

lqiu96
Copy link
Contributor

@lqiu96 lqiu96 commented Sep 27, 2022

The *.java changes are found in: #8448

Looks to have been reverted as part of #8340

@lqiu96 lqiu96 mentioned this pull request Sep 27, 2022
Closed
@lqiu96 lqiu96 added the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 27, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 27, 2022
@snippet-bot
Copy link

snippet-bot bot commented Sep 27, 2022 •
edited
Loading

Here is the summary of possible violations 😱

There is a possible violation for not having product prefix.

The end of the violation section. All the stuff below is FYI purposes only.

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@lqiu96
Copy link
Contributor Author

lqiu96 commented Sep 27, 2022 •
edited
Loading

Seems like all the previous PRs have the modified README and adds in the samples/ dir. It looks like it's also adding in renovate.json

@meltsufin
Copy link
Member

Seems like all the previous PRs have the modified README and adds in the samples/ dir. It looks like it's also adding in renovate.json

We probably need to add an exclusion. These are not hand-written samples, but examples for how to use bom vs. without. It's also worth considering keeping these in the monorepo. We should discuss this more.

lqiu96
lqiu96 commented Sep 28, 2022
View reviewed changes
java-vision/samples/pom.xml
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
<modelVersion>4.0.0</modelVersion>
<groupId>com.google.cloud</groupId>
<artifactId>google-cloud--samples</artifactId>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm guessing the samples pom.xml has a typo: https://github.com/googleapis/java-vision/blob/2076f657d012d9e02f553f34a663fbd00a75cc28/samples/pom.xml#L5

lqiu96
lqiu96 commented Sep 28, 2022
View reviewed changes
java-vision/samples/snapshot/pom.xml
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
<modelVersion>4.0.0</modelVersion>
<groupId>com.google.cloud</groupId>
<artifactId>-snapshot</artifactId>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here. https://github.com/googleapis/java-vision/blob/2076f657d012d9e02f553f34a663fbd00a75cc28/samples/snapshot/pom.xml#L5

lqiu96
lqiu96 commented Sep 28, 2022
View reviewed changes
java-vision/samples/snippets/pom.xml
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
<modelVersion>4.0.0</modelVersion>
<groupId>com.google.cloud</groupId>
<artifactId>-snippets</artifactId>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As well as here

lqiu96
lqiu96 commented Sep 28, 2022
View reviewed changes
java-vision/samples/install-without-bom/pom.xml
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
<modelVersion>4.0.0</modelVersion>
<groupId>com.google.cloud</groupId>
<artifactId>-install-without-bom</artifactId>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here as well

@lqiu96
Copy link
Contributor Author

lqiu96 commented Sep 28, 2022

Seems like all the previous PRs have the modified README and adds in the samples/ dir. It looks like it's also adding in renovate.json

We probably need to add an exclusion. These are not hand-written samples, but examples for how to use bom vs. without. It's also worth considering keeping these in the monorepo. We should discuss this more.

I think that's fair then. We should probably update the ./delete_non_generated_samples.sh then: https://github.com/googleapis/google-cloud-java/blob/bce011719e8eef293899f29f1cba596e09046225/generation/delete_non_generated_samples.sh

@meltsufin meltsufin added the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 29, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 29, 2022
@meltsufin
Copy link
Member

Seems like all the previous PRs have the modified README and adds in the samples/ dir. It looks like it's also adding in renovate.json

We probably need to add an exclusion. These are not hand-written samples, but examples for how to use bom vs. without. It's also worth considering keeping these in the monorepo. We should discuss this more.

I think that's fair then. We should probably update the ./delete_non_generated_samples.sh then: https://github.com/googleapis/google-cloud-java/blob/bce011719e8eef293899f29f1cba596e09046225/generation/delete_non_generated_samples.sh

Why don't we see owlbot do this on other PRs in this repo?

@lqiu96
Copy link
Contributor Author

lqiu96 commented Sep 29, 2022 •
edited
Loading

Web Security Scanner: #8471
It's being added in from this commit (Owl-bot post processor): 11841fa

This PR I opened up for the diffs also has the samples being added in. Also, both PRs seems to have the samples' artifactId being invalid.
<artifactId>-snapshot</artifactId> -- Looking like an error with populating values in the template

@lqiu96
Copy link
Contributor Author

lqiu96 commented Oct 7, 2022

Closing as no longer an issue: #8448

@lqiu96 lqiu96 closed this Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lqiu96 @meltsufin