feat: service settings as a bean #1110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhumin8
reviewed
Dec 5, 2022
.../com/google/api/generator/spring/composer/goldens/EchoSpringAutoConfigurationGrpcRest.golden
Outdated
Show resolved
Hide resolved
blakeli0
reviewed
Dec 6, 2022
src/main/java/com/google/api/generator/spring/composer/SpringAutoConfigClassComposer.java
Outdated
Show resolved
Hide resolved
zhumin8
added
the
spring
zhumin8
reviewed
Dec 7, 2022
src/main/java/com/google/api/generator/spring/composer/SpringAutoConfigClassComposer.java
Outdated
Show resolved
Hide resolved
|
Kudos, SonarCloud Quality Gate passed! |
emmileaf
approved these changes
Dec 14, 2022
1 task
zhumin8
added a commit
that referenced
this pull request
Dec 16, 2022
…1123) As discussed off-line, instead of depending on a new `global-properties` module, use `CredentialsProvider` bean from `spring-cloud-gcp-autoconfigure` instead. - Replace dependency from `core` to `autoconfigure` module. - Revert #1071 and implement changes shown in [poc](zhumin8/language_poc1#7) - Minor code cleanups and util method extracted from `SpringPropertiesClassComposer.java`. Note: #1071 and GoogleCloudPlatform/spring-cloud-gcp#1308 will be obsolete after this change. Also, conflicts needs to be resolved between this pr and #1110 depending on merging order.
|
@diegomarquezp I missed this earlier in review. But can you open a separate PR to update the relevant javadoc comments affected by this change? |
|
@zhumin8 will do! |
zhumin8
added a commit
that referenced
this pull request
Jan 4, 2023
#1209) Addressing: #1110 (comment) This was leftover from changes made in #1110
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables usage of
[Service]Settingsas a separate bean, as suggested in GoogleCloudPlatform/spring-cloud-gcp#1364 (comment)Changes were based on POC by @zhumin8 and POC fixes by @emmileaf