fix(spring): Replace global properties with CredentialsProvider bean #1123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng-cloud-gcp-autoconfigure from globalProperties..
zhumin8
requested review from
meltsufin,
blakeli0,
diegomarquezp and
emmileaf
|
Kudos, SonarCloud Quality Gate passed! |
meltsufin
approved these changes
Dec 15, 2022
1 task
zhumin8
added
the
spring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed off-line, instead of depending on a new
global-propertiesmodule, useCredentialsProviderbean fromspring-cloud-gcp-autoconfigureinstead.coretoautoconfiguremodule.SpringPropertiesClassComposer.java.Note: #1071 and GoogleCloudPlatform/spring-cloud-gcp#1308 will be obsolete after this change.
Also, conflicts needs to be resolved between this pr and #1110 depending on merging order.