Fixed initialization called multiple times #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -33,6 +30,9 @@ private void setUpMapIfNeeded() { | |||
| return; | |||
| } | |||
| mMap = ((SupportMapFragment) getSupportFragmentManager().findFragmentById(R.id.map)).getMap(); | |||
| if (mMap != null) { | |||
| startDemo(); | |||
| } | |||
There was a problem hiding this comment.
I recall moving startDemo() to onResume() because some demo I was working on didn't have the camera initialised at the onCreate() step.
Could you remove the setUpMapIfNeeded() call from onStart()?
There was a problem hiding this comment.
It's not a problem setUpMapIfNeeded is called in various places. Actually it is good for these rare cases, where user didn't update Google Play Services app.
if (mMap != null) {
return;
}
stops startDemo from being called multiple times.
There was a problem hiding this comment.
IIRC, I was trying to call moveCamera() inside onCreate(). I think it was too early. But this will work fine for all demos that exist at the moment.
broady
added a commit
that referenced
this pull request
Aug 16, 2013
…ple_times Call startDemo() only once.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See how compareDistanceBetween demo behaves when you open it, press HOME and go back. There are 4 markers.