Skip to content

Fixed initialization called multiple times #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 16, 2013
Merged

Fixed initialization called multiple times #13

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions demo/src/com/google/maps/android/utils/demo/BaseDemoActivity.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,16 +23,16 @@ public void onCreate(Bundle savedInstanceState) {
protected void onResume() {
super.onResume();
setUpMapIfNeeded();
if (getMap() != null) {
startDemo();
}
}

private void setUpMapIfNeeded() {
if (mMap != null) {
return;
}
mMap = ((SupportMapFragment) getSupportFragmentManager().findFragmentById(R.id.map)).getMap();
if (mMap != null) {
startDemo();
}
Copy link
Contributor

@broady broady Aug 15, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recall moving startDemo() to onResume() because some demo I was working on didn't have the camera initialised at the onCreate() step.

Could you remove the setUpMapIfNeeded() call from onStart()?

Copy link
Contributor Author

@mg6maciej mg6maciej Aug 16, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not a problem setUpMapIfNeeded is called in various places. Actually it is good for these rare cases, where user didn't update Google Play Services app.

    if (mMap != null) {
        return;
    }

stops startDemo from being called multiple times.

Copy link
Contributor

@broady broady Aug 16, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRC, I was trying to call moveCamera() inside onCreate(). I think it was too early. But this will work fine for all demos that exist at the moment.

}

/**
Expand Down