Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rendering for leisure=dog_park #341

Closed
alexandre-mbm opened this issue Feb 18, 2014 · 16 comments · Fixed by #2216
Closed

Add rendering for leisure=dog_park #341

alexandre-mbm opened this issue Feb 18, 2014 · 16 comments · Fixed by #2216
Labels
enhancement landcover new features Requests to render new features
Milestone

Comments

@alexandre-mbm
Copy link

leisure=park is used for public recreation spaces in Brazil. These parks can contain dog parks. But leisure=dog_park isn't rendering over leisure=park. See here.

It would be interesting a leisure=garden similar rendering, adding a soft edge in order to contrast the green background.

@vholten
Copy link
Contributor

vholten commented Feb 18, 2014

Currently, leisure=dog_park is never rendered. See also https://trac.openstreetmap.org/ticket/2482.

@matkoniecz matkoniecz changed the title To render leisure=dog_park within leisure=park render leisure=dog_park Aug 28, 2014
@matthijsmelissen matthijsmelissen changed the title render leisure=dog_park Add rendering for leisure=dog_park Sep 24, 2014
@matthijsmelissen matthijsmelissen added this to the New features milestone Sep 26, 2014
@neiljp
Copy link

neiljp commented Mar 15, 2015

Given some recent objects I've come across, it would be interesting to see these rendered (darker/hatched green? little dog image inside?), and with waste=* tags and the waste bins starting to be rendered, these combined features would make dog walking a useful application of OSM :)
(I'm not a dog walker/owner, though)

@1ec5
Copy link

1ec5 commented Jul 4, 2015

There are standalone dog parks, too, and it’s unfortunate that those parks are left unstyled and unlabeled.

@kocio-pl
Copy link
Collaborator

kocio-pl commented Jul 4, 2015

I think that might be another candidate to have colored borders.

@dieterdreist
Copy link

I propose a highly transparent black fill (won't change colors), eg rgba 0,0,0,0.15

These will typically have fences, hence an outline.

@jdhoek
Copy link
Contributor

jdhoek commented Jul 7, 2016

Based on the icon contributed by Giardia, I have created a first draft of this feature. Comments welcome.

  • Fill colour is darken(@park, 5%), visible from zoom-level 10 onwards
  • Dog paw icon is drawn from zoom-level 16 onwards
  • No outline

I have omitted the outline, because the tag leisure=dog_park can mean either a standalone fenced of area, or a larger area in a park where there may not be any fence (instead relying on natural boundaries and attentive dog owners). The latter is the case in the example shown here, which is a real park in The Netherlands.

Examples

Screenshots from Kosmtik. Please ignore the misaligned bridge, that was a mistakenly moved point since restored.

Zoom 16

dog16

Zoom 17

dog17

Zoom 18

dog18

Zoom 19

dog19

@kocio-pl
Copy link
Collaborator

kocio-pl commented Jul 7, 2016

Nice idea, but looks to me too like natural=scrub. Could you try to modify it to be easier to recognize?

@jdhoek
Copy link
Contributor

jdhoek commented Jul 7, 2016

Slightly more explicit paws, darker and larger. Compare with the natural=scrub on the left.

dog17a

I'd rather not change the hue of the green in order to stay with the park's fill colour.

@kocio-pl
Copy link
Collaborator

kocio-pl commented Jul 7, 2016

Thanks, it works for me!

@jdhoek
Copy link
Contributor

jdhoek commented Jul 7, 2016

Great. PR will follow when I finish implementing the bit for point as well as the area.

jdhoek added a commit to jdhoek/openstreetmap-carto that referenced this issue Jul 7, 2016
Dog parks are rendered in a slightly darker shade of the fill colour
used for parks.

The 'paw' icon is based on work contributed to the public domain by Trac
user Giardia¹.

This closes gravitystorm#341.

1: https://trac.openstreetmap.org/ticket/2482
@jdhoek
Copy link
Contributor

jdhoek commented Jul 7, 2016

Points now show just the paw icon.

dogs

I am happy with the polygon area, which in this sample has a name, but I can't figure out how to render the name of the point below its icon, without also moving the text of the polygon down. That is, I can add text-dy: 12, and the name of the point will show up neatly below the paw icon, but that also moves the text of the polygon dog-park down. Anyway to achieve what I want without that happening?

@jdhoek
Copy link
Contributor

jdhoek commented Jul 7, 2016

This is what happens when I introduce text-dy: 10.

dogstoolow

The point looks great, but the polygon has its text too low. Is there a way to apply styling only to point-based targets?

jdhoek added a commit to jdhoek/openstreetmap-carto that referenced this issue Jul 7, 2016
Dog parks are rendered in a slightly darker shade of the fill colour
used for parks.

The 'paw' icon is based on work contributed to the public domain by Trac
user Giardia¹.

This closes gravitystorm#341.

1: https://trac.openstreetmap.org/ticket/2482
jdhoek added a commit to jdhoek/openstreetmap-carto that referenced this issue Jul 7, 2016
Dog parks are rendered in a slightly darker shade of the fill colour
used for parks.

The 'paw' icon is based on work contributed to the public domain by Trac
user Giardia¹.

This closes gravitystorm#341.

1: https://trac.openstreetmap.org/ticket/2482
@matthijsmelissen
Copy link
Collaborator

Looks nice, thanks for your work!

For areas, we use italic text that scales with area size. See for example the rules for the text for forest. Perhaps it works to create two different rules, one for areas and one for points?

I don't think we currently distinguish between areas and points, but maybe it works to pass an extra constant in the relevant SQL queries (there is one query for areas and one for points)?

@jdhoek
Copy link
Contributor

jdhoek commented Jul 7, 2016

dogsitalic

This adjusts the styling to match common area styling.

jdhoek added a commit to jdhoek/openstreetmap-carto that referenced this issue Jul 7, 2016
Dog parks are rendered in a slightly darker shade of the fill colour
used for parks.

The 'paw' icon is based on work contributed to the public domain by Trac
user Giardia¹.

This closes gravitystorm#341.

1: https://trac.openstreetmap.org/ticket/2482
@jdhoek
Copy link
Contributor

jdhoek commented Jul 7, 2016

Perhaps I'll leave it like this for now. If a dog park has a name, it won't be shown if the park is defined on a point, but behaves as expected when defined on a polygon. Most dog parks appear to be polygons. I have no idea how many dog parks actually have names — the one I added (and which lead me to this issue) is part of a larger park.

@HolgerJeromin
Copy link
Contributor

I think detail mapping with a name is often combined with mapping as an area.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement landcover new features Requests to render new features
Projects
None yet
Development

Successfully merging a pull request may close this issue.

10 participants