Update dog park rendering #4384
Conversation
Remove the pattern fill and unify rendering style with playgrounds at high zoom levels.
| [feature = 'leisure_dog_park'][zoom >= 17] { | ||
| marker-file: url('symbols/shop/pet.svg'); | ||
| marker-fill: @leisure-green; | ||
| marker-clip: false; | ||
| } | ||
|
|
||
| [feature = 'leisure_dog_park'][zoom >= 17], | ||
| [feature = 'leisure_playground'][zoom >= 17] { | ||
| marker-file: url('symbols/leisure/playground.svg'); | ||
| [feature = 'leisure_playground'] { | ||
| marker-file: url('symbols/leisure/playground.svg'); | ||
| } | ||
| [feature = 'leisure_dog_park'] { | ||
| marker-file: url('symbols/shop/pet.svg'); | ||
| } |
There was a problem hiding this comment.
This change unifies the dog_park and playground styling.
| text-fill: @leisure-green; | ||
| text-halo-radius: @standard-halo-radius * 1.5; /* Extra halo needed to stand out from paw pattern. */ | ||
| text-halo-fill: @standard-halo-fill; | ||
| } |
There was a problem hiding this comment.
This removes pattern fill styling and replaces it with the simple fill used by park/village green/recreation_ground
| @@ -88,6 +88,7 @@ | |||
|
|
|||
| [feature = 'leisure_recreation_ground'][zoom >= 10], | |||
| [feature = 'landuse_recreation_ground'][zoom >= 10], | |||
| [feature = 'leisure_dog_park'][zoom >= 13], | |||
There was a problem hiding this comment.
Adds casing to dog_parks to match playgrounds.
| [feature = 'leisure_dog_park'] { | ||
| [zoom >= 10] { | ||
| polygon-fill: @leisure; | ||
| [way_pixels >= 4] { polygon-gamma: 0.75; } | ||
| [way_pixels >= 64] { polygon-gamma: 0.3; } | ||
| } | ||
| [zoom >= 16] { | ||
| polygon-pattern-file: url('symbols/dog_park.png'); | ||
| polygon-pattern-alignment: global; | ||
| [way_pixels >= 4] { polygon-pattern-gamma: 0.75; } | ||
| [way_pixels >= 64] { polygon-pattern-gamma: 0.3; } | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
Removes pattern fill from dog parks. Polygon fill is already handled elsewhere.
|
Additional before/after example from Bristol, Connecticut, USA (location: https://www.openstreetmap.org/#map=14/41.6877/-72.9577) Screen shots demonstrating no change in label rendering behavior at lower zoom (zoom 14 in this example):
|
|
Thanks, that is a significant improvement. |
|
You are probably not consciously aware of this but this is kind of the last step in a sequence of highly questionable design choices - most of which were made without consensus among the maintainers and which according to what this PR suggested would lead to rendering dog parks identical to playgrounds - an idea that seems ridiculous if you subscribe to the paradigm that differences in color should reflect differences in function and purpose for the target map user and which by the way massively supports the stereotype that OSM is a project of male tech nerds without kids and who view caring for a kid and caring for a dog as similar in nature as well as the view that this project is dominated by the narrow perspective of an urban European/North American temperate climate clientele with their specific views of animal keeping (leisure=dog_park is still the only feature specific to animal keeping we have in this style so far and we render it in a green color implying vegetation as if globally dogs are always kept/walked in vegetated areas). The history starts essentially with adding dog_park rendering in #2216 (sample rendering in #341), criticized in #2250. Playground rendering was changed from the traditional well recognizable cyan tone to a meaningless non-distinctive green in #2249 to which various other features were piggy-bagged later (#2891 - note that leisure=fitness_station and leisure=fitness_centre are unified with playgrounds, not with pitch or track - or stadium, sports_centre, which were later unified in #2954) and recreation_ground (#2964 which was unified with playground and not with park to which is is practically a synonym) including dog_park with its base color in #2268 (while keeping a distinction via pattern). I don't want to repeat all the considerations why these changes were in a disadvantageous direction from these issues - see also #2270. The dog_park rendering is also still a lingering problem in the ac-style by the way, i have not yet gotten around addressing that. My thought however goes into the direction of looking towards the farmyard/farmland colors to establish a distinct color for animal keeping features (see also #4260). This is all of course not your fault - in the current situation i understand this change might make some sense. But the better approach would IMO be to take a step back and look at the larger picture of landcover fill colors in this style and how to get back to a systematic strategy in that domain. |
In fact, in the United States, dog parks are very much designed to function as playgrounds for pets, and their popularity as such is by no means limited to males, tech nerds, or dense urban environments. But I suppose this is the americentrism you refer to, given your observation in #2270 (comment) that the two features couldn’t be more dissimilar. What are dog parks like in other places that would be difficult to reconcile with this rendering?
#3966 and #4260 propose more animal-related features, but to me it seems that dog parks are much more closely associated with playgrounds than animal boarding, animal shelters, or veterinarians (which are rendered). Do you have in mind other not-yet-rendered features that could be part of a whole coherent category of animal-related features? Or is your core point that dog parks simply should not be rendered in the first place?
I wouldn’t think the fill or label color could be taken literally anyways. After all, playgrounds in the U.S. aren’t usually vegetated: mulched or rubberized surfaces are the norm, and trees and landscaping are a luxury not often found in simple neighborhood or school playgrounds. Yet green is a sensible color for playgrounds, since they are so commonly park amenities. That could too could be a regional difference, but green playground icons are common even in maps tailored to the U.S., where they couldn’t be mistaken for vegetation-related features. |
|
The green is used for various leisure purposes. I see no problem with having the same colour at low zoom, and we have clearly distinctive icons when looking close. |
|
I am not really keen on discussing the culture and role of animal keeping in different parts of the world and its similarity to child-rearing here - my comments in that direction were meant to encourage developers to reflect on their selective perception of the field. As said what is missing here (seriously and desperately missing IMO since 2016) is an overall color design strategy with consensus support. That is what #2270 is for. And the way to get there is not by making local convenience choices for selecting individual colors by finding a free spot in color space or overloading a suitably undefined existing color with an additional meaning and then ex post facto rationalizing that to be reconcilable with reality.
I have no issue with rendering leisure=dog_park provided that a suitable rendering can be found (and so far i do not consider this to be the case for any of the variants tried). We can only render what mappers actually record in a consistent fashion. That dog parks are the only animal-keeping related feature we render so far is not exclusively caused by the perception and experience bias of the developers here, it is at least as much due to an equally narrow perspective among most mappers. The lack of clear, well defined, documented and consistently used tagging schemes for practically the whole domain of livestock keeping is testimony to that. |
|
For clarification - due to #2270 (comment) - the above comments are not a negative review, they are meant to provide useful historic context to the change this PR proposes. I will however not positively review or merge this change unless someone can convince me of its merits. |
|
This change requires review by someone other than me. |
|
Closing so other contributors can work on this. |
This PR removes the
leisure=dog_parkpattern fill and unifies the rendering style with playgrounds at high zoom levels.Fixes #3041 (id of the issue to be closed)
Test rendering with links to the example places:
Berlin: https://www.openstreetmap.org/#map=16/52.4769/13.2607
New York City: https://www.openstreetmap.org/#map=18/40.74897/-74.00707
Berlin, zoom 13
Berlin, zoom 16
New York City, zoom 17
New York City, zoom 18
