Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dog park color change #2268

Merged
merged 1 commit into from
Aug 8, 2016
Merged

Dog park color change #2268

merged 1 commit into from
Aug 8, 2016

Conversation

meased
Copy link
Contributor

@meased meased commented Aug 5, 2016

Continuation of #2216. Attempting to solve #2250.

Render dog parks like playgrounds with a paw pattern background.

dogparkinpark
(with barrier=fence)

dogpark

dog_park_node

@dieterdreist
Copy link

sent from a phone

Il giorno 05 ago 2016, alle ore 05:15, meased notifications@github.com ha scritto:

Render dog parks like playgrounds with a paw pattern background.

while dog parks and playgrounds could be seen as similar features from a conceptual point of view, for practical usage this idea seems counterproductive. It would lead to playgrounds and dog parks look the same without the pattern (in lower zoom levels) and therefore neither serve dog owners nor parents

@kocio-pl
Copy link
Collaborator

kocio-pl commented Aug 5, 2016

@dieterdreist You're right about this effect, but for me it's highly preferable to hide details on lower zoom levels. I would definitely like to recognize them in micro scale, but on lower zoom levels only bigger/more complex structures should be visible, like parks and schools, not the playgrounds, dog parks or pitches, which are common parts of them.

@meased What about different colors for icon and label on points?

@meased
Copy link
Contributor Author

meased commented Aug 5, 2016

Text and icon are different colors only because we currently render playgrounds on nodes that way. The reason I went with playground color for areas was to avoid making another green. Campground color may be another option.

@kocio-pl
Copy link
Collaborator

kocio-pl commented Aug 5, 2016

Oh, you're right! For me this version is worth merging as it is, but we still have to fix the general color inconsistency for leisure label/icon (see #1794).

@matthijsmelissen
Copy link
Collaborator

@meased What about different colors for icon and label on points?

Is this related to #1355?

@kocio-pl
Copy link
Collaborator

kocio-pl commented Aug 7, 2016

No, I was talking only about matching icon and label colors, they don't have to match background color for me (look at the hospital colors for icon+label vs background).

@matthijsmelissen matthijsmelissen merged commit 668e689 into gravitystorm:master Aug 8, 2016
@matthijsmelissen
Copy link
Collaborator

Thanks! Looks good to me too.

@michaelzangl
Copy link

michaelzangl commented Aug 16, 2016

This was a feature I missed for a long time.

In Karlsruhe, we have dog park areas that e.g. are covered by trees. They are not rendered the right way since dog parks are rendered as solid textures - the same way the land cover is.

I suggest changing the texture background to be transparent or semi-transparent and/or increasing the z-index of dog park so that it is displayed above the landcover.

Example:
Bad: http://www.openstreetmap.org/#map=19/48.99757/8.37287
Good: http://www.openstreetmap.org/#map=19/48.99132/8.40570

@kocio-pl
Copy link
Collaborator

@gravitystorm thinks that transparency is bad solution, so it's just out of question currently. We use simple heuristic however: smaller areas are rendered on bigger areas, so if the trees are just a part of dog park, they would cover it (see in the park), but it seems that in your case the dog park is small area compared to one big area with trees, so it is rendered on top.

@michaelzangl
Copy link

michaelzangl commented Aug 16, 2016

I know that heuristic. I think it makes perfect sense for "normal" areas. But a dog park - at least in our town, is more like a natural resort marked by signs and does not necessary need to be a separate area.

We could also render the paw symbols on top of the forest background, like #landcover-area-symbols. The tree symbols are already drawn over a dog park, it should at least work the other way around.

@dieterdreist
Copy link

sent from a phone

Il giorno 16 ago 2016, alle ore 17:45, kocio-pl notifications@github.com ha scritto:

@gravitystorm thinks that transparency is bad solution

I think he is only against alpha values >0 and <1 because of "unpredictable" colors, while 0 and 1 are both OK.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants