-
Notifications
You must be signed in to change notification settings - Fork 821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rendering of leisure=dog_park
#2216
Add rendering of leisure=dog_park
#2216
Conversation
6d15e39
to
64c06c5
Compare
Dog parks are rendered in a slightly darker shade of the fill colour used for parks. The 'paw' icon is based on work contributed to the public domain by Trac user Giardia¹. This closes gravitystorm#341. 1: https://trac.openstreetmap.org/ticket/2482
64c06c5
to
bd4b0c6
Compare
Thanks, looks good! |
Huh - that was fast. I am not sure if the base color is a good idea here - both in terms of similarity with other colors and using another distinct color for a really specialized feature. Could we get some sample renders? For me this does not really have much similarity to leisure=park despite the name - i would put it more next to http://wiki.openstreetmap.org/wiki/Tag:leisure%3Dhorse_riding the latter three in combination with Maybe it would make sense to develop a general concept to render animal sports areas in the wider sense. |
According to the code it is not park color, it is To me a facility like the one in the photo has more similarities with a (relatively informal) sports area. Given the large variety of animal sports and non-agricultural keeping of animals that exists internationally i think a common base design (possibly with varying pattern) for all of these would be a good idea - and probably using the park color or a park-like color would not be ideal for that. |
@imagico Dog parks are usually a small standalone park or a part of a larger park (either fenced off or simply as an area designated by signs) where dog owners can let their dogs run around unleashed. This to me is quite dissimilar to sports areas (for man or animal), hence the darkened Please see #341 for my sample renders. |
But that is fairly culture specific - it probably varies strongly between different countries, just like the incidence of dog parks compared to similar facilities for other types of animals.
Could you point out where you draw the line here - it might make sense to work this into the tag definition then. Right now leisure=dog_park specifically includes obstacle tracks for example which is in my eyes a sports related feature.
Ok, thanks - there are different designs shown there so i am not too sure which is the one now implemented here - i assume it is more or less the last one shown. I think the pattern symbols are too strong - generally a pattern should be significantly more subtle than individual point symbols, otherwise overall readability of the map suffers. Since the base color is a darker and stronger green than leisure=park which is characterized by maintained, gardened plants, in dry areas usually also irrigated while leisure=dog_park does not necessarily imply any vegetation the choice of color - even assuming a general similarity to leisure=park - appears somewhat non-intuitive to me. Note the chosen color has the highest chroma value of all green area tones in this style currently. |
@imagico Please have a look at the original Trac issue as well for the discussion of this feature. I think most of the concerns have been raised and addressed there and in #341. The OSM wiki defines
(emphasis mine) From my understanding this rules out actual dog sports such as dog racing (is that a thing?). I agree that areas used for training of dogs sit somewhere between park and sports, but I got the impression from the original feature request that Currently the colour values chosen sit between park and sports area in terms of intensity. I chose the current (higher) contrast of the paws in response to a comment from @kocio-pl (the lighter version seemed too close to |
I think there could be confusion on the tag definition since rendering this while not rendering any other dog related facilities in a distinct way will widen use of this tag so having well defined limits to where it applies would be a good idea. Around here there are many areas for more serious dog training - both commercial 'dog schools' as well as training courses from dog owner clubs etc.
Intensity is not a very well defined term w.r.t. color. As said in terms of chroma (or saturation) this is the most 'colorful' green area tone currently in the style.
I definitely will once this change is released but i was hoping this could be fixed before the next release. |
sent from a phone
around here (Rome) these are quite common and they are usually a part of the park, separated by a fence, but otherwise not different from the rest of the park, save the different drinking water fountains. You'd find them in most of the bigger parks but also in many of the smaller ones. dog type visible here (and also the usual types): |
sent from a phone
around here have no sports whatsoever association, it's dog owners meeting other dog owners and unleashing the dogs, but typically neither the owners nor the dogs move particularly fast ;-) |
Sorry, I don't think this is an improvement. It reminds me of the old rendering of zoos and I was glad that we got rid of that. The paws are far too prominent and since we have removed a lot of regular patterns lately I don't think it is good to re-introduce a new one. edit: also the pattern source file is not included. |
sent from a phone
are these generally accessible to the public? Or do you need to get an appointment, pay a fee and respect opening hours, become member or client, etc.? Is there staff? There's a lot of differences |
Don't know, don't have a dog. But i am pretty sure if this is the only dog specific tag rendered people will start tagging such things with leisure=dog_park unless the tag definition specifically excludes this and there is a better tag for this kind of facility. |
@nebulon42: The difference is that zoo is a big area with structure that should be visible (some buildings, footways, animal areas, ponds, toilets etc.) while dog park is uncomplicated amenity and I guess its area is always quite small. Probably single paw icon would be less controversial, but I'm not opposed to paw area - especially in the example shown in the issue ticket. However if there are some places where the area is bigger I might reconsider my position on this. |
sent from a phone
yes, but I doubt it would stop if the definition explicitly excluded other dog facilities as long as there aren't tags for them "available" |
This might be personal, but I find the original pattern more pleasant to the eye. |
In my view current pattern is OK, since we want to show something is designed and random patterns mean that the feature is rather natural/not planned and this is not the case (but it makes perfect sense for scrub!). What about the colors however? Do you want to change background to park color and paws to a new value or you just didn't care about the colors? |
I do agree that the current colors are a bit bright, both foreground and background. I like the park color for the background, and think the pattern alone would be enough to show a dog_park within a park (especially if combined with barrier=fence, which it probably should be). I have no strong feelings on the pattern, just putting options on the table. I like the planned/not planned reasoning. |
Closed dog parks should have a fence mapped. If they are open (no fence) in a park it is probably OK to not render the outline as there is no clear border in reality, too. |
Depends on the local situation. In the Netherlands these kind of areas are often delimited by natural boundaries instead of fences, so a slightly different background colour helps to distinguish the area from the surrounding park and other grassy areas. @meased By the way, if you want to change the colours, open a new pull request if you can do it yourself, or a new issue if you need someone to help you and refer to this pull request. This is a pull request that has already been merged — it is effectively dead. |
Dog parks are rendered in a slightly darker shade of the fill colour
used for parks.
The 'paw' icon is based on work contributed to the public domain by Trac
user Giardia¹.
This closes #341.
1: https://trac.openstreetmap.org/ticket/2482