gui: Update default font to Inter-Regular and console font to Inconsolata #1908

opsinphark · 2020-10-03T22:11:04Z

First run at importing assets from https://github.com/madmaxpayne/Gridcoin-wallet-redesign.

Adds Inter as the default font and Inconsolata as the RPC console font
The font SF Pro cannot be used according to Apple's legal policy. It has been replaced with Inter which uses the Open Font License.
More information about Inter can be found here:
https://fonts.google.com/specimen/Inter?query=inter

More information about Inconsolata can be found here:
https://fonts.google.com/specimen/Inconsolata?query=Inconsolata

For DPI scaling issues we might have to move to using % for font-size instead of px or pt.
px pixels (1px = 1/96th of 1in) (fixed width)
pt points (1pt = 1/72 of 1in) (fixed width)
% (sets to a percent of the parent element)

Both of these changes will make the font universal over all platforms as they are compiled into the binaries themselves. Hopefully this will provide some display consistency.

Note:
The stylesheets need to be reworked entirely at some point. These commits should satisfy the scope of this PR.

Screenshots:

The Inconsolata font keeps the fixed width aspect for the RPC console:

- This font is licensed under the Open Font License. - https://fonts.google.com/specimen/Inter?query=inter

jamescowens

I think you are missing native_stylesheet.qss, right?

I like moving towards the new assets.

src/qt/rpcconsole.cpp

src/qt/res/stylesheets/dark_stylesheet.qss

opsinphark · 2020-10-04T03:29:52Z

I think you are missing native_stylesheet.qss, right?

I like moving towards the new assets.

opsinphark · 2020-10-04T03:32:04Z

I think you are missing native_stylesheet.qss, right?
I like moving towards the new assets.

The native_stylesheet.qss is actively referenced anywhere in the code, it's merely there to provide a starting basis for a new stylesheet. It is beyond outdated and probably needs to be updated using the light or dark stylesheet.

jamescowens · 2020-10-04T03:48:58Z

Are you sure about that? There is a native selection in the style drop down in the GUI, and it is definitely different than light.

jamescowens · 2020-10-04T03:49:18Z

Further, native is actually better than light IMHO.

jamescowens · 2020-10-04T03:51:39Z

The stylesheets are a mess quite frankly, and cycy and I didn't have time to fully fix them for the Fern release. If you want to take a shot at really getting them straight, that's great. Let's do it in a different PR than this though. Let's constrain this one to fix the main font + the console.

jamescowens · 2020-10-04T03:54:59Z

Compiling your PR for testing now...

opsinphark · 2020-10-04T03:57:01Z

The stylesheets are a mess quite frankly, and cycy and I didn't have time to fully fix them for the Fern release. If you want to take a shot at really getting them straight, that's great. Let's do it in a different PR than this though. Let's constrain this one to fix the main font + the console.

Your right, it didn't see it loading at QT_ENABLE, it has bare minimum effects though. I will add the RPC font into the native stylesheet.

Yes, they are a mess. The styles are combined both in the C++ and stylesheets, so some elements might override the other.

After adding the RPC font to the native stylesheet all that is left is finding the right size for the RPC console icon.
Working on this now.

jamescowens · 2020-10-04T04:29:33Z

I just tried this to no effect...

ui->messagesWidget->document()->setDefaultStyleSheet(
            "table { }"
            "td.time { font-family: Inconsolata; color: #808080; valign: bottom;} "
            "td.message { font-family: Inconsolata; valign: bottom; } "
            "td.cmd-request { color: #006060; } "
            "td.cmd-error { color: red; } "
            "b { color: #006060; } "
            );

opsinphark · 2020-10-04T04:33:55Z

I just tried this to no effect...

ui->messagesWidget->document()->setDefaultStyleSheet(
            "table { }"
            "td.time { font-family: Inconsolata; color: #808080; valign: bottom;} "
            "td.message { font-family: Inconsolata; valign: bottom; } "
            "td.cmd-request { color: #006060; } "
            "td.cmd-error { color: red; } "
            "b { color: #006060; } "
            );

I've added the RPC console font to the native stylesheet. This should fix all the issues beyond the icon size in the console.

SCRATCH THAT.
The native stylesheet does not work properly as it's missing several elements. It needs to be entirely reworked to include the elements from the 'light' & 'dark' stylesheets.

Will continue to work on this tomorrow. I've spotted a few other spots that have scaling issues. It's majorly frustrating to have three stylesheets that do not have the same elements.

src/qt/rpcconsole.cpp

jamescowens · 2020-10-04T04:45:44Z

Ok. I got the right font to show up in the console...

jamescowens · 2020-10-04T04:46:41Z

I had to do

QFontDatabase::addApplicationFont(":/fonts/inconsolata-regular");
QFont messagesFont("inconsolata", 10);

ui->lineEdit->setFont(messagesFont);

ui->messagesWidget->document()->setDefaultFont(messagesFont);
ui->messagesWidget->document()->setDefaultStyleSheet(
            "table { }"
            "td.time { color: #808080; valign: bottom;} "
            "td.message { valign: bottom; } "
            "td.cmd-request { color: #006060; } "
            "td.cmd-error { color: red; } "
            "b { color: #006060; } "
            );

jamescowens · 2020-10-04T04:47:02Z

The lineEdit is still not the right font...

jamescowens

Please make the requested changes. Thanks.

src/qt/bitcoingui.cpp

src/qt/rpcconsole.cpp

jamescowens · 2020-10-04T04:51:39Z

Ok. I saw your comments on making further changes to the stylesheets.

jamescowens · 2020-10-04T04:54:42Z

Some other things to point out while you are at it where the NATIVE stylesheet is better...

Native...

Dark or Light...

Notice that the labels on the icons are truncated for dark or light, but the menu items are too close together for native. You are going to have to be very careful to ensure you get the best behavior across the board when you straighten these out. Hippocratic Oath applies too... do no harm...

jamescowens · 2020-10-04T05:14:13Z

I got it to work correctly with all three styles, and the proportional font is the correct one too...

Please see jamescowens@376785c

opsinphark · 2020-10-04T05:16:22Z

So here is where we are at, I think we both might be commenting to fast.
As this PR sits right now, the font is added correctly in bitcoingui.cpp & rpcconsole.cpp. The first issue is the native_stylesheet.qss has several missing elements and does not functional properly. The second issue is that of DPI scaling (which is why your screenshots appear truncated) . I am trying to track down both now.

Light or Dark: (both have the correct default and rpc console fonts)

Native: (has the correct default font but will not display the correct rpc font)

jamescowens · 2020-10-04T05:22:26Z

Alright. Let's see after you make further changes tomorrow. You can look at my branch if it helps at all.

dblanch256 · 2020-10-04T05:53:55Z

Gentlemen, If this is the wrong way to report this, I apologize in advance. I've been running the Gridcoin 5.0.1 wallet for several weeks now and have seen the following "Error Message:" content on the main GUI a half a dozen times or so. It doesn't seem to hurt anything that I can see, but I thought you'd like to know: Alert: EXCEPTION: NSt8ios_base7failureB5cxx11E EnumBytes out of range: iostream error C:\Program Files\GridcoinResearch\gridcoinresearch.exe in ProcessMessages() ; David C Blanchard MIT '76 609.238.3895 *"If I have seen a little farther than others, it is because I have stood on the shoulders of giants"* -- Isaac Newton *"If I have not seen as far as others, it is because giants were standing on my shoulders."* -- Hal Abelson *"In the field of Computer Science, we stand on each others' feet."* -- Richard Hamming

…

On Sun, Oct 4, 2020 at 1:22 AM James C. Owens ***@***.***> wrote: Alright. Let's see after you make further changes tomorrow. You can look at my branch if it helps at all. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#1908 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AKW7PY2YS5GZQUPA7DXBRD3SJABCHANCNFSM4SDI65XQ> .

- Adds the font Inconsolata-Regular to the application database. This font is licensed under the Open Font License. More information can be found here: https://fonts.google.com/specimen/Inconsolata?query=Inconsolata - Sets the global default font to 10pt rather than pixels to deal with any further DPI scaling issues. - Fixes missing elements in native_stylesheet.css that were not alllowing the RPC font to display correctly in the RPC console. (The stylesheets really need to be reworked entirely although this satisfies the scope of this PR)

opsinphark · 2020-10-04T07:29:59Z

All stylesheets have been fixed and are displaying both fonts properly.
The stylesheets need to be reworked entirely, although these commits satisfy the scope of this pull request.
If you pulling from my repository for test building purposes all my changes have been squashed and forced updated so you probably will have to use git pull --force to receive all of the changes.
I have statically built and tested for x86_64-pc-linux-gnu. I can provide the binaries if necessary.

jamescowens · 2020-10-04T15:00:22Z

@dblanch256 that is an ignorable issue that has been reported several times, thanks. Someone is trying to inject a v2 (block version 11 transaction too early with fields that are out of range in the v10 protocol. The wallet is appropriate rejecting the transactions even though the error message is cryptic. BTW, normally you create a new issue for something like that, rather than mix in to an unrelated one... :)

jamescowens · 2020-10-04T15:01:10Z

@opsinphark I will build from your PR here...

opsinphark · 2020-10-04T16:53:51Z

Still noticing with Hi-DPI turned on the light and dark stylesheets still have truncated items.
Trying to track the elements.

jamescowens · 2020-10-04T17:27:24Z

The font still wasn't right on my build. Please see this...

jamescowens · 2020-10-04T17:28:06Z

I made a couple of changes. It works now (at least the fonts, not the other issues you mentioned above)...

jamescowens · 2020-10-04T17:28:45Z

This is the correct font.

jamescowens · 2020-10-04T17:29:15Z

I will PR to your branch...

jamescowens · 2020-10-04T17:35:31Z

See opsinphark#1

You have to register both fonts in the bitcoingui.cpp file, because registering it in the rpcconsole.cpp file is too late. The main style sheets have already been processed. Also you need to use the alias names not the actual file names for the resources.

Modifications to PR1908 to get fonts to initialize correctly

jamescowens · 2020-10-04T18:00:22Z

BTW, I agree wholeheartedly with you on the DPI scaling. I actually put a DPI ratio to 96 in a few places to scale the icons correctly. We need to adopt a general scaling approach I think. There is also the HiPDI switch or something with the newer Qt. Might want to look into that. Not sure how that works.

jamescowens

Looks good.

jamescowens · 2020-10-04T18:07:52Z

I will go ahead and merge this one, and we can start working on straightening out the rest of the stylesheet problems and HiDPI issues on a new one.

jamescowens · 2020-10-05T01:54:31Z

It was the border: none; settings that was causing the truncation in the toolbar icon labels. Go figure. I think it is a bug. See my PR that is the continuation of the fixup... #1911

gui: Update default font to Inter-Regular

912d115

- This font is licensed under the Open Font License. - https://fonts.google.com/specimen/Inter?query=inter

jamescowens reviewed Oct 4, 2020

View reviewed changes

src/qt/rpcconsole.cpp Outdated Show resolved Hide resolved

src/qt/res/stylesheets/dark_stylesheet.qss Outdated Show resolved Hide resolved

opsinphark force-pushed the gui-update1 branch from c627082 to 81a2c22 Compare October 4, 2020 03:25

opsinphark force-pushed the gui-update1 branch from 81a2c22 to 5646011 Compare October 4, 2020 04:31

jamescowens reviewed Oct 4, 2020

View reviewed changes

src/qt/rpcconsole.cpp Outdated Show resolved Hide resolved

jamescowens requested changes Oct 4, 2020

View reviewed changes

src/qt/bitcoingui.cpp Outdated Show resolved Hide resolved

src/qt/rpcconsole.cpp Outdated Show resolved Hide resolved

src/qt/rpcconsole.cpp Outdated Show resolved Hide resolved

opsinphark force-pushed the gui-update1 branch from 5646011 to 730d3ab Compare October 4, 2020 07:20

Change resource paths to aliases and move QFontDatabase call

440c8f3

Merge pull request #1 from jamescowens/PR1908

8d1bb87

Modifications to PR1908 to get fonts to initialize correctly

jamescowens approved these changes Oct 4, 2020

View reviewed changes

jamescowens changed the title ~~gui: Update default font to Inter-Regular~~ gui: Update default font to Inter-Regular and console font to Inconsolata Oct 4, 2020

jamescowens assigned opsinphark Oct 4, 2020

jamescowens added bug enhancement labels Oct 4, 2020

jamescowens added this to the Gladys milestone Oct 4, 2020

jamescowens added the gui label Oct 4, 2020

jamescowens merged commit 3b7a596 into gridcoin-community:development Oct 4, 2020

jamescowens linked an issue Oct 4, 2020 that may be closed by this pull request

Console and Icons Don't Scale On High DPI Displays #1111

Closed

jamescowens mentioned this pull request Oct 5, 2020

gui: Adjust stylesheets and scale icons to improve HiDPI side toolbar display #1911

Merged

cyrossignol mentioned this pull request Oct 5, 2020

gui: Install bold variant of Inter font #1914

Merged

jamescowens mentioned this pull request Oct 5, 2020

Verbose Logging Error since 4.0.2 #1445

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

gui: Update default font to Inter-Regular and console font to Inconsolata #1908

gui: Update default font to Inter-Regular and console font to Inconsolata #1908

opsinphark commented Oct 3, 2020 •

edited

Loading

jamescowens left a comment

opsinphark commented Oct 4, 2020

opsinphark commented Oct 4, 2020

jamescowens commented Oct 4, 2020

jamescowens commented Oct 4, 2020

jamescowens commented Oct 4, 2020

jamescowens commented Oct 4, 2020

opsinphark commented Oct 4, 2020 •

edited

Loading

jamescowens commented Oct 4, 2020

opsinphark commented Oct 4, 2020 •

edited

Loading

jamescowens commented Oct 4, 2020

jamescowens commented Oct 4, 2020

jamescowens commented Oct 4, 2020

jamescowens left a comment

jamescowens commented Oct 4, 2020

jamescowens commented Oct 4, 2020

jamescowens commented Oct 4, 2020

opsinphark commented Oct 4, 2020

jamescowens commented Oct 4, 2020

dblanch256 commented Oct 4, 2020 via email

opsinphark commented Oct 4, 2020

jamescowens commented Oct 4, 2020

jamescowens commented Oct 4, 2020

opsinphark commented Oct 4, 2020

jamescowens commented Oct 4, 2020

jamescowens commented Oct 4, 2020

jamescowens commented Oct 4, 2020 •

edited

Loading

jamescowens commented Oct 4, 2020

jamescowens commented Oct 4, 2020

jamescowens commented Oct 4, 2020

jamescowens left a comment

jamescowens commented Oct 4, 2020

jamescowens commented Oct 5, 2020

gui: Update default font to Inter-Regular and console font to Inconsolata #1908

gui: Update default font to Inter-Regular and console font to Inconsolata #1908

Conversation

opsinphark commented Oct 3, 2020 • edited Loading

jamescowens left a comment

Choose a reason for hiding this comment

opsinphark commented Oct 4, 2020

opsinphark commented Oct 4, 2020

jamescowens commented Oct 4, 2020

jamescowens commented Oct 4, 2020

jamescowens commented Oct 4, 2020

jamescowens commented Oct 4, 2020

opsinphark commented Oct 4, 2020 • edited Loading

jamescowens commented Oct 4, 2020

opsinphark commented Oct 4, 2020 • edited Loading

jamescowens commented Oct 4, 2020

jamescowens commented Oct 4, 2020

jamescowens commented Oct 4, 2020

jamescowens left a comment

Choose a reason for hiding this comment

jamescowens commented Oct 4, 2020

jamescowens commented Oct 4, 2020

jamescowens commented Oct 4, 2020

opsinphark commented Oct 4, 2020

jamescowens commented Oct 4, 2020

dblanch256 commented Oct 4, 2020 via email

opsinphark commented Oct 4, 2020

jamescowens commented Oct 4, 2020

jamescowens commented Oct 4, 2020

opsinphark commented Oct 4, 2020

jamescowens commented Oct 4, 2020

jamescowens commented Oct 4, 2020

jamescowens commented Oct 4, 2020 • edited Loading

jamescowens commented Oct 4, 2020

jamescowens commented Oct 4, 2020

jamescowens commented Oct 4, 2020

jamescowens left a comment

Choose a reason for hiding this comment

jamescowens commented Oct 4, 2020

jamescowens commented Oct 5, 2020

opsinphark commented Oct 3, 2020 •

edited

Loading

opsinphark commented Oct 4, 2020 •

edited

Loading

opsinphark commented Oct 4, 2020 •

edited

Loading

jamescowens commented Oct 4, 2020 •

edited

Loading