gui: Adjust stylesheets and scale icons to improve HiDPI side toolbar display #1911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Before.... After... (this also includes the new fonts and changes in #1908. |
jamescowens
force-pushed
the
toolbar_fixes
branch
from
ea913b2 to
ff80e9c
Compare
|
Glad you figured out where the stylesheet issues, it was driving me mad. |
cyrossignol
approved these changes
Oct 5, 2020
|
Apparently there is a bug of some sort in the border (or border-style): none. When you use that, it truncates the labels, like it is using a ridiculously thick invisible border. Unfortunately getting rid of the none creates a small visible border on the "light" stylesheet, but it is better than truncating the labels. I also implemented a simple scaling rule for the icons. I did the same thing for the field widths or something similar in the peers tab when I did that a while back. Seems to work pretty well. This will get us by until you do some more thorough house cleaning, if you want, @opsinphark! |
|
I'm poking around a bit to see what I want to conquer next. |
jamescowens
changed the title
jamescowens
changed the title
jamescowens
added a commit
that referenced
this pull request
Oct 8, 2020
…cyrossignol) - refactor: port chainparams #1878 (@div72) - gui: Update default font to Inter-Regular and console font to Inconsolata (@opsinphark, @jamescowens) - gui: Add "review beacon verification" button to wizard summary page #1912 (@cyrossignol) - rpc, wallet: Implement liststakes #1909 (@jamescowens) - rpc: Add "getlaststake" RPC function #1913 (@cyrossignol) - gui: Install bold variant of Inter font #1914 (@cyrossignol) - refactor: Consolidate Gridcoin-specific code #1894 (@cyrossignol) - script: Setup improvements #1895 (@nathanielcwm) - gui: Diagnostics refresh #1899 (@jamescowens) - superblock: Optimize superblock size calculation #1906 (@cyrossignol) - gui: Adjust stylesheets and scale icons to improve HiDPI side toolbar display #1911 (@jamescowens) - doc: Tell user to disable win32 application support in WSL (for building) #1917 (@nathanielcwm) - rpc: Revise and expand help for beaconconvergence rpc call #1918 (@jamescowens) - scheduler: Increase default update check interval to 5 days #1920 (@cyrossignol) - gui: Prevent multiple dialogs from being open at the same time #1922 (@scribblemaniac) - refactor: Clean up remaining legacy timer code #1892 (@cyrossignol) - build: Add --without-brotli option to curl.mk #1902 (@G_UK) - test: Remove fs_tests... file after the fs test #1903 (@div72) - util, gui: Fix shutdown segfault and repair broken overview page staking status #1901 (@jamescowens) - scraper: Fix order of destruction for global scraper objects #1904 (@cyrossignol) - scraper: Fix global object destruction order for MacOS #1905 (@cyrossignol) - util: Decouple out-of-sync state from block acceptance #1921 (@cyrossignol)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes some stylesheet adjustments to make the menu bar consistent, fix truncation of the side toolbar icon labels, and also scale the side toolbar icons on HiDPI displays. Further work will need to be done on the stylesheets as they still are quite bizarre.