script: Setup Improvements #1895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not entirely sure how to make the installer. With makensis it doesn't seem to create it properly. |
|
make deploy
…Sent from my iPhone
On Sep 23, 2020, at 9:55 AM, Nathaniel Chin ***@***.***> wrote:
Not entirely sure how to make the installer. With makensis it doesn't seem to create it properly.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
|
I believe it doesn't work for the 32 bit setup. |
|
I will check today. |
also read registry for 32 bit installer
nathanielcwm
force-pushed
the
patch-1
branch
from
51f3441 to
b852566
Compare
|
Looks like b852566 broke some stuff that didn't break on my machine lol |
Also replace 32x32 icon with 256x256 icon
nathanielcwm
force-pushed
the
patch-1
branch
from
b852566 to
c1dc1e0
Compare
|
I am testing this now. |
jamescowens
approved these changes
Sep 29, 2020
jamescowens
added a commit
that referenced
this pull request
Oct 8, 2020
…cyrossignol) - refactor: port chainparams #1878 (@div72) - gui: Update default font to Inter-Regular and console font to Inconsolata (@opsinphark, @jamescowens) - gui: Add "review beacon verification" button to wizard summary page #1912 (@cyrossignol) - rpc, wallet: Implement liststakes #1909 (@jamescowens) - rpc: Add "getlaststake" RPC function #1913 (@cyrossignol) - gui: Install bold variant of Inter font #1914 (@cyrossignol) - refactor: Consolidate Gridcoin-specific code #1894 (@cyrossignol) - script: Setup improvements #1895 (@nathanielcwm) - gui: Diagnostics refresh #1899 (@jamescowens) - superblock: Optimize superblock size calculation #1906 (@cyrossignol) - gui: Adjust stylesheets and scale icons to improve HiDPI side toolbar display #1911 (@jamescowens) - doc: Tell user to disable win32 application support in WSL (for building) #1917 (@nathanielcwm) - rpc: Revise and expand help for beaconconvergence rpc call #1918 (@jamescowens) - scheduler: Increase default update check interval to 5 days #1920 (@cyrossignol) - gui: Prevent multiple dialogs from being open at the same time #1922 (@scribblemaniac) - refactor: Clean up remaining legacy timer code #1892 (@cyrossignol) - build: Add --without-brotli option to curl.mk #1902 (@G_UK) - test: Remove fs_tests... file after the fs test #1903 (@div72) - util, gui: Fix shutdown segfault and repair broken overview page staking status #1901 (@jamescowens) - scraper: Fix order of destruction for global scraper objects #1904 (@cyrossignol) - scraper: Fix global object destruction order for MacOS #1905 (@cyrossignol) - util: Decouple out-of-sync state from block acceptance #1921 (@cyrossignol)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main purpose of this was to make the setup read the existing install location from the registry.
I also resized some of the bitmaps which makes them look better for example: