Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gui: Install bold variant of Inter font #1914

Merged
merged 1 commit into from
Oct 5, 2020

Conversation

cyrossignol
Copy link
Member

@cyrossignol cyrossignol commented Oct 5, 2020

This is a small follow-up for #1908.

I added the bold variant for the "Inter" font. This improves rendering accuracy and style faithfulness of bold-style text because the rendering engine can use the font data directly instead of extrapolating boldness from the regular variant. I also replaced the regular variant with a desktop font. The original appears to be a web font that doesn't include additional hinting data that may improve legibility in environments that support advanced font shaping (ClearType).

I did not include the italic variants because we don't use this style anywhere that I can see.

Before | After:

image

The screenshot isn't a great example because it's running from a remote Linux session, but it does illustrate the differences between the shapes of the glyphs.

Copy link
Member

@jamescowens jamescowens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good.

@jamescowens jamescowens added this to the Gladys milestone Oct 5, 2020
@jamescowens jamescowens merged commit 67d01ec into gridcoin-community:development Oct 5, 2020
@cyrossignol cyrossignol deleted the inter-bold branch October 5, 2020 13:55
@jamescowens
Copy link
Member

Maybe, but that is bigger right? And a related question since cycy brought it up, does the variable font include all the sub-pixel hinting for cleartype/etc?

@jamescowens
Copy link
Member

We could play around with that in another PR...

@cyrossignol
Copy link
Member Author

Inter's variable fonts do not have the hints.

But honestly, after staring at the hinted text for a day, something subtle about the way they're rasterized makes me really hate them. Can't put my finger on it. Might have something to do with the forced 10pt size across the board.

So I'm all for swapping out the constant font files for the variable font. @opsinphark You want to do that? Should cut down the size of the final binary.

@opsinphark
Copy link
Contributor

I can start a new PR for moving to the the variable font. Might take some playing around with to find the font right size that displays well in both normal and scaled aspects.

@opsinphark
Copy link
Contributor

I've created a new PR for this, please checkout #1926

jamescowens added a commit that referenced this pull request Oct 8, 2020
…cyrossignol)

 - refactor: port chainparams #1878 (@div72)
 - gui: Update default font to Inter-Regular and console font to Inconsolata (@opsinphark, @jamescowens)
 - gui: Add "review beacon verification" button to wizard summary page #1912 (@cyrossignol)
 - rpc, wallet: Implement liststakes #1909 (@jamescowens)
 - rpc: Add "getlaststake" RPC function #1913 (@cyrossignol)
 - gui: Install bold variant of Inter font #1914 (@cyrossignol)

 - refactor: Consolidate Gridcoin-specific code #1894 (@cyrossignol)
 - script: Setup improvements #1895 (@nathanielcwm)
 - gui: Diagnostics refresh #1899 (@jamescowens)
 - superblock: Optimize superblock size calculation #1906 (@cyrossignol)
 - gui: Adjust stylesheets and scale icons to improve HiDPI side toolbar display #1911 (@jamescowens)
 - doc: Tell user to disable win32 application support in WSL (for building) #1917 (@nathanielcwm)
 - rpc: Revise and expand help for beaconconvergence rpc call #1918 (@jamescowens)
 - scheduler: Increase default update check interval to 5 days #1920 (@cyrossignol)
 - gui: Prevent multiple dialogs from being open at the same time #1922 (@scribblemaniac)

 - refactor: Clean up remaining legacy timer code #1892 (@cyrossignol)

 - build: Add --without-brotli option to curl.mk #1902 (@G_UK)
 - test: Remove fs_tests... file after the fs test #1903 (@div72)
 - util, gui: Fix shutdown segfault and repair broken overview page staking status #1901 (@jamescowens)
 - scraper: Fix order of destruction for global scraper objects #1904 (@cyrossignol)
 - scraper: Fix global object destruction order for MacOS #1905 (@cyrossignol)
 - util: Decouple out-of-sync state from block acceptance #1921 (@cyrossignol)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants