refactor: Consolidate Gridcoin-specific code #1894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyrossignol
force-pushed
the
reorganize-gridcoin
branch
from
419c8ee to
eaae673
Compare
This also fixes cyclical header dependency issues.
cyrossignol
force-pushed
the
reorganize-gridcoin
branch
from
eaae673 to
8beb015
Compare
jamescowens
added
compatibility
enhancement
refactor
|
Very good. I will go through this today, but first glance looks like the right approach for packaging to prepare us for the base code rebase work. |
jamescowens
approved these changes
Sep 24, 2020
jamescowens
added a commit
that referenced
this pull request
Oct 8, 2020
…cyrossignol) - refactor: port chainparams #1878 (@div72) - gui: Update default font to Inter-Regular and console font to Inconsolata (@opsinphark, @jamescowens) - gui: Add "review beacon verification" button to wizard summary page #1912 (@cyrossignol) - rpc, wallet: Implement liststakes #1909 (@jamescowens) - rpc: Add "getlaststake" RPC function #1913 (@cyrossignol) - gui: Install bold variant of Inter font #1914 (@cyrossignol) - refactor: Consolidate Gridcoin-specific code #1894 (@cyrossignol) - script: Setup improvements #1895 (@nathanielcwm) - gui: Diagnostics refresh #1899 (@jamescowens) - superblock: Optimize superblock size calculation #1906 (@cyrossignol) - gui: Adjust stylesheets and scale icons to improve HiDPI side toolbar display #1911 (@jamescowens) - doc: Tell user to disable win32 application support in WSL (for building) #1917 (@nathanielcwm) - rpc: Revise and expand help for beaconconvergence rpc call #1918 (@jamescowens) - scheduler: Increase default update check interval to 5 days #1920 (@cyrossignol) - gui: Prevent multiple dialogs from being open at the same time #1922 (@scribblemaniac) - refactor: Clean up remaining legacy timer code #1892 (@cyrossignol) - build: Add --without-brotli option to curl.mk #1902 (@G_UK) - test: Remove fs_tests... file after the fs test #1903 (@div72) - util, gui: Fix shutdown segfault and repair broken overview page staking status #1901 (@jamescowens) - scraper: Fix order of destruction for global scraper objects #1904 (@cyrossignol) - scraper: Fix global object destruction order for MacOS #1905 (@cyrossignol) - util: Decouple out-of-sync state from block acceptance #1921 (@cyrossignol)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a series of mostly trivial, move-only changes that reorganize Gridcoin-specific code into the "gridcoin" directory to prepare for a full-scale upgrade of the base Bitcoin code. This PR separates almost all of the remaining Gridcoin core functionality from the Bitcoin tree except for some necessary customizations to data structures and APIs.
I also left the RPCs and miner-related code alone entirely. These are more involved areas that warrant focused PRs of their own and may be easier to refactor while in the process of merging upstream changes. I also see no need to mess with the organization of the GUI code at this time because we won't likely port Bitcoin's GUI code as it is.
Please read the commit descriptions for details. We can probably squash some of these if desired. I kept the breakdown for clarity and to make adjustments easier if we don't agree on the proposed organization.