Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix vlan id should be integer type (backport #1099) #1101

Merged

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Aug 13, 2024

Summary

  • fix vlan id should be integer type
  • allow user to modify vlan Id with empty value
  • ensure input value should between 1 ~ 4094

PR Checklist

  • Is this a multi-tenancy feature/bug?
    • Yes, the relevant RBAC changes are at:
  • Do we need to backport changes to the old Rancher UI, such as RKE1?
    • Yes, the relevant PR is at:
  • Are backend engineers aware of UI changes?
    • Yes, the backend owner is:

Related Issue #

Occurred changes and/or fixed issues

Technical notes summary

Note. this PR should backport to v1.4 / v1.3 / v1.2

Areas which could experience regressions

Screenshot/Video

fixed.mov

This is an automatic backport of pull request #1099 done by [Mergify](https://mergify.com).

Signed-off-by: andy.lee <andy.lee@suse.com>
(cherry picked from commit 79bd332)
@mergify mergify bot mentioned this pull request Aug 13, 2024
3 tasks
@a110605 a110605 self-assigned this Aug 13, 2024
@a110605 a110605 requested a review from bk201 August 13, 2024 02:23
@a110605 a110605 merged commit 2294e06 into release-harvester-v1.3 Aug 13, 2024
6 checks passed
@mergify mergify bot deleted the mergify/bp/release-harvester-v1.3/pr-1099 branch August 13, 2024 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants