-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removing Riviera SDK [Part 1 of 2] #289
Conversation
3884c58
to
0eacb84
Compare
0eacb84
to
4ae97ab
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
This PR supersedes the work done by @sebastus in PR's #191 / #190 / #178 - and fully removes the Riviera Client from the codebase. A second PR will migrate the
azure.String
methods into the ProviderTasks:
azurerm_resource_group
to use the Azure SDK for Go instead of Rivieraazurerm_sql_database
to use the Azure SDK for Go instead of Rivieraazurerm_sql_firewall_rule
to use the Azure SDK for Go instead of Rivieraazurerm_sql_database
azurerm_sql_*
resources are detectedencryption
field onazurerm_sql_database
azurerm_sql_elasticpool
sample code failsFixes #255 #49 #93