[WIP] Taint and resource address #12224
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Module resource were being sorted lexically by name by the state filter. If there are 10 or more resources, the order won't match the index order, and resources will have different indexes in their new location. Sort the FilterResults by index numerically when the names match. Clean up the module String output for visual inspection by sorting Resource name parts numerically when they are an integer value.
…raform into taint-and-resource-address
huydinhle
changed the title
fix sorting of module resources during state mv
The containerservice package fell behind the others. Fix the vendor.json file to match the vendored packages.
The github.com/aws/aws-sdk-go/service/configservice package was updated without being reflected in the manifest.
multiple scaleway-cli packages were out of sync, unfortunately this pulled in some other updates.
Update some ssh subpackages to match the top-level commit Update the curve25519 package, and manuallly fix the checksum to include the non-amd64 source.
this is still broken on solaris
github.com/scaleway/scaleway-cli/pkg/utils can be imported because it depends on github.com/moul/gotty-client which can't build on solaris. This requires removing the github.com/scaleway/scaleway-cli/pkg/api/helpers.go file which imports the utils package, and we don't use. Not sure how we'll handle this if the structure of the scaleway package changes and we can't break this import any longer.
govendor pulled these in, not sure why.
HCL identifiers may need to be quoted, so always quote them to be safe.
This reverts commit 43f62d2.
HCL identifiers may need to be quoted, so always quote them to be safe.
Change the expected outputs in the Push tests to match the quotes map keys.
also increase the timeout for slow test hosts.
Always quote identifiers when encoding HCL
…test remove log.Fatal from test
… type is provided. The original error appears to have been copied from the CodeBuild resource and provides incorrect information about valid types.
…hanges argument permission to the correct name permissions.
|
I'd suggest rebasing this into one commit, will make it easier to review. |
…raform into taint-and-resource-address
|
@heraclmene good point, let me try to clean it up. Thank you. |
|
I messed up my git history, and I don't know how to fix it, so I just open new Pr to replace this one. |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Doc Update
Relevant Terraform version
About Acceptance Test.
Questions