[blocked] provider/aws: Allow ordering of cache_behaviors in CF distribution

[radeksimko]

Fixes #7253

Depends on (i.e. blocked by) #7485

Summary

• cache_behavior + default_cache_behavior were changed from TypeSet to TypeList to reflect ordering given by the HCL config
• allowed_methods + cached_methods were changed from TypeList to TypeSet because AWS API returns these in pretty much random order which is generating extra diffs + updates
• state migration + test added

Test plan

make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSCloudFrontDistribution'

TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSCloudFrontDistribution -timeout 120m
=== RUN   TestAccAWSCloudFrontDistribution_S3Origin
--- PASS: TestAccAWSCloudFrontDistribution_S3Origin (946.92s)
=== RUN   TestAccAWSCloudFrontDistribution_customOrigin
--- PASS: TestAccAWSCloudFrontDistribution_customOrigin (810.02s)
=== RUN   TestAccAWSCloudFrontDistribution_multiOrigin
--- PASS: TestAccAWSCloudFrontDistribution_multiOrigin (896.46s)
=== RUN   TestAccAWSCloudFrontDistribution_noOptionalItemsConfig
--- PASS: TestAccAWSCloudFrontDistribution_noOptionalItemsConfig (934.08s)
=== RUN   TestAccAWSCloudFrontDistribution_noCustomErrorResponseConfig
--- PASS: TestAccAWSCloudFrontDistribution_noCustomErrorResponseConfig (955.18s)
=== RUN   TestAccAWSCloudFrontDistribution_cacheBehaviorPrecedence
--- PASS: TestAccAWSCloudFrontDistribution_cacheBehaviorPrecedence (1015.78s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/aws    5558.474s

[adamb0mb]

I'd love to see this merged!

[apparentlymart]

As part of the the Terraform 0.10 release earlier this year, all of the Terraform providers were moved to their own repositories in the terraform-providers GitHub organization, and removed from the Terraform Core repository.

Unfortunately due to the fact that new issues and pull requests are being opened constantly, it was not possible for the various provider maintainers to merge all outstanding pull requests before this split, and there is no automatic way to migrate a pull request to a new repository.

As a result, this pull request can sadly no longer be applied as-is, and so I'm going to close it.

If someone has the time and motivation to apply same changes to the aws provider repository and open a new PR there, the maintainers of that provider should be able to review and merge it.

Thanks again for working on this, and sorry it was not able to be merged before the provider repository changes.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.