(WIP) Update cloudfront behaviors to behave like lists and allow for ordering #9167
Conversation
|
Well, tempted to close this... seems like you have it under control! |
| s := []interface{}{} | ||
| for _, v := range cbs.Items { | ||
| s = append(s, flattenCacheBehavior(v)) | ||
| } | ||
| return schema.NewSet(cacheBehaviorHash, s) | ||
| //return schema.NewSet(cacheBehaviorHash, s) |
There was a problem hiding this comment.
Whoops should delete that commented out part
|
Hi @PayscaleNateW |
radeksimko
added
bug
waiting-response
|
@radeksimko Actually, #7485 fixed it perfectly, thanks! I pulled down your commits. I had a few merge conflicts with #7395 so I didn't give too much effort to cherry-pick that one. But it looks like your fix is way more thorough. I definitely recommend merging those in |
|
Now trying to write acceptance tests and I'm getting It doesn't seem like the logs bucket is defined anywhere in the mock configs? Also, when I do define one, there may be a race condition where the bucket doesn't get created in time for cloudfront to get it. Maybe Amazon just started doing that validity check? I also notice that simply trying terraform apply using that as the config file has the same error. The s3 buckets get created, but not in time for cloudfront to use them. |
|
I believe there is a bug there pertaining to the logging bucket not being previously defined. However, I was running into issues with my naming when I tried to fix it. The name of the bucket should be a name, for example mylogs., and then the logging_config should have its bucket as mylogs..s3.amazonaws.com I think I fixed this in |
|
I'd love to see this or #7395 merged! |
|
Echo @adamb0mb! |
mitchellh
removed
the
waiting-response
|
Hello @PayscaleNateW, and thanks for working on this! As part of the the Terraform 0.10 release earlier this year, all of the Terraform providers were moved to their own repositories in the terraform-providers GitHub organization, and removed from the Terraform Core repository. Unfortunately due to the fact that new issues and pull requests are being opened constantly, it was not possible for the various provider maintainers to merge all outstanding pull requests before this split, and there is no automatic way to migrate a pull request to a new repository. As a result, this pull request can sadly no longer be applied as-is, and so I'm going to close it. If you or someone else has the time and motivation to apply same changes to the Thanks again for working on this, and sorry it was not able to be merged before the provider repository changes. |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
#7253
However, some setbacks:
Still encountering a bug that maybe someone can help me with... I get an index out of bounds exception when I run
terraform applydue to this line:cloudfront_distribution_configuration_structure.go
ForwardedValues: expandForwardedValues(m["forwarded_values"].(*schema.Set).List()[0].(map[string]interface{})),There may also be a bug in field_reader.go addrToSchema. I'm not sure that code is robust against crazy combinations of nested sets and lists.
TODO: