helper/schema: Make nested Set(s) in List(s) work (2) #7485
Conversation
radeksimko
changed the title
radeksimko
force-pushed
the
b-schema-set-in-list
branch
2 times, most recently
from
9fb0a4b to
240f5bd
Compare
radeksimko
changed the title
|
Some tests still seem to be failing, was this expected? |
Those are unrelated acceptance test failures. |
|
Then what is holding this PR back? I would love #7395 to be implemented soon :) |
radeksimko
force-pushed
the
b-schema-set-in-list
branch
from
240f5bd to
a727c0c
Compare
|
I have just rebased this which also restarted tests and should remove the relationship with failing Travis build w/ acceptance tests. It is possible that we may delay merging this PR (i.e. #7395 too) until 0.7 is out - which should be very soon. 😉 |
radeksimko
force-pushed
the
b-schema-set-in-list
branch
from
a727c0c to
8811feb
Compare
radeksimko
force-pushed
the
b-schema-set-in-list
branch
from
8811feb to
58e8910
Compare
|
Any updates on this now 0.7 is out? :) |
Although DiffFieldReader was the one mostly responsible for a buggy behaviour more tests were added throughout the debugging process most of which would fail without the bugfix. - ResourceData - MultiLevelFieldReader - MapFieldReader - DiffFieldReader
radeksimko
force-pushed
the
b-schema-set-in-list
branch
from
58e8910 to
b136f73
Compare
|
Hey @radeksimko, I'm interested in getting this into master but it appears to panic on tests when rebased now. Can you rebase this and take a look? |
|
Hey @radeksimko is this a thing you plan to complete sometime, or can it be closed? 😄 |
|
Let's close this for now. |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
This is a second (patched) version of #7393 which had to be reverted because some acceptance tests were failing as part of the nightly run.
Related to #7253 & #7254
Supersedes/fixes #7268
Blocking #7395
The only difference from the original PR is the last commit (
50fbe79).I managed to reproduce schema diff edge cases from the failing tests in
awsprovider and fix those. I added 3 new unit tests to cover this new functionality.I ran the 16 (previously failing) aws acceptance tests, all are now passing. I also ran first
aws141 of total 464 acceptance tests which all (eventually) passed.I don't have a Fastly account so I would appreciate if someone could double check all acceptance tests are passing there too and generally run the whole shebang once again with this patch (possibly before merging).