forked from trialspark/sqlalchemy-continuum
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Original continuum #1
Draft
JaymoKang
wants to merge
119
commits into
master
Choose a base branch
from
original-continuum
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
little grammar fix
…ment improve memory usage for vacuum on large tables
Fixes for a couple of issues related to using multiple schemas
…y-continuum into oinopion-fix-changeset
As stated on kvesteri#101, quickstart example doesn't work as is. I've adapted the snippet to let it work without problem if someone copy and paste it.
As stated on kvesteri#101, quickstart example doesn't work as is. I've adapted the snippet to let it work without problem if someone copy and paste it.
Update snippets on documentation
…_relationships don't include excluded properties
Hotfix/track cloned connections (trialspark#2) Hotfix/track cloned connections (trialspark#3) change iterations use only ConnectionFairy as indexes create new dict entry for clones create entry using old connection create entry using session revert to event listening strategy remove cloned connections on rollback treat None case when cleaning connections Hotfix/track cloned connections (trialspark#2) Hotfix/track cloned connections (trialspark#3) change iterations use only ConnectionFairy as indexes create new dict entry for clones create entry using old connection create entry using session revert to event listening strategy remove cloned connections on rollback treat None case when cleaning connections
…onnections track cloned connections
Raising a new KeyError means you lose the original stacktrace, which is going to be more useful since it'll contain more information about the relevant context for this error.
…ption Reraise original exception instead of a new one
…ails without TransactionChanges plugin" and fix that has Transaction.entity_names raise a NoChangesColumn instead of AttributeError.
…ansaction_changes.py and tests/inheritance/test_single_table_inheritance.py
…ject to scalar subquery Tested by running `DB=sqlite py.test tests`. With master: 653 passed, 99 skipped, 4909 warnings in 65.90s (0:01:05) With this change: 653 passed, 99 skipped, 4695 warnings in 64.93s (0:01:04)
fix for unit_of_work.py:263: SAWarning: implicitly coercing SELECT object to scalar subquery
Following Flask-Login documentation we should use current_user.get_id() instead of current_user.id. (closes kvesteri#149) https://flask-login.readthedocs.io/en/latest/#your-user-class Signed-off-by: Jiri Kuncar <jiri.kuncar@cern.ch>
fix issue 85 "TransactionBase.changed_entities fails without TransactionChanges plugin"
Pass sync_triggers kwargs through to create_triggers Allows use of native versioning without mod tracking
Previously we seem to have relied on the login state not being preserved across contexts, but it's now moved to `g`. Using login_user instead of grovelling inside flask-login internals does the trick.
When handling assoc tables, we use the existing properties and use them for another query for the version tables. But if we modify the existing dict - in some dialects, that causes the original query to be modified (For example oracle with cx-oracle library) Avoid mutating the properties to avoid such issues.
…ECT object to scalar subquery
* fixes for scalar_subquery and subquery warnings in SQLA>=1.4 Co-authored-by: Mark Steward <marksteward@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.