-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(deps): add support for react 18 #322
Conversation
Hi @100terres, thank you for working on this and keeping this package alive. |
wtf would you fork to add React 18 dependency and not publish the package? Some problem with the code running under React 18? |
Re-read my comment. Apologize for the wording. Thanks for the release. |
c663c72
to
552b8f7
Compare
This will allow @react-forked/dnd to be installed using react v18 fix #319
* test(dev-deps): remove enzyme libraries from package.json * test(setup): remove enzyme related configuration * test: move REACT_VERSION global declaration * test(dev-deps): setup @testing-library/jest-dom for more details see: https://github.com/testing-library/jest-dom#usage= * test(jsdom env): fix issue with missing TransitionEvent * test(enzyme): drop Placeholder without memo (needed for enzyme) * test(enzyme): drop force upfate util * test(enzyme): drop PassThroughProps util component Not needed anymore, because with @testing-library/react there are no equivalent to the `setProp`. We must use the `rerender` function and we can directly change the prop of child component in the tree if needed. * test(util): drop un-used user input util * test(enzyme): migrate all tests using enzyme to @testing-library/react * chore: bump size snapshot
… set (#392) also reactor how we manipulate environment variables in our test
Exacly! React 18 brought a couple of breaking changes and it was not an easy fix. Also some of our depedencies needed to be upgraded and in the case of enzyme we needed to completly drop it and use something else. There had been a lot of investigations and code changes. |
fix #293