Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/metrics-server] Update 'metrics-server' to v0.3.3. #15919

Closed
wants to merge 1 commit into from
Closed

[stable/metrics-server] Update 'metrics-server' to v0.3.3. #15919

wants to merge 1 commit into from

Conversation

bmcustodio
Copy link
Contributor

@bmcustodio bmcustodio commented Jul 26, 2019 •
edited
Loading

What this PR does / why we need it:

This PR updates metrics-server to v0.3.3.

Which issue this PR fixes

N/A

Special notes for your reviewer:

N/A

Checklist

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [stable/chart])

@bmcustodio
Update 'metrics-server' to v0.3.3.
4b6cf46 
Signed-off-by: Bruno Miguel Custódio <brunomcustodio@gmail.com>
@helm-bot helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 26, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bmcstdio
To complete the pull request process, please assign olemarkus
You can assign the PR to them by writing /assign @olemarkus in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

Hi @bmcstdio. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 26, 2019
olemarkus
olemarkus suggested changes Jul 26, 2019
View reviewed changes
stable/metrics-server/Chart.yaml
@@ -2,7 +2,7 @@ apiVersion: v1
appVersion: 0.3.2
description: Metrics Server is a cluster-wide aggregator of resource usage data.
name: metrics-server
version: 2.8.2
version: 2.8.3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bump minor version here

stable/metrics-server/Chart.yaml
@@ -2,7 +2,7 @@ apiVersion: v1
appVersion: 0.3.2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bump version here too

@pierluigilenoci pierluigilenoci mentioned this pull request Aug 20, 2019
Closed
4 tasks
@olemarkus
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 20, 2019
@k8s-ci-robot
Copy link
Contributor

@bmcstdio: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-charts-e2e 4b6cf46 link /test pull-charts-e2e

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@pierluigilenoci pierluigilenoci mentioned this pull request Aug 27, 2019
Closed
4 tasks
@pierluigilenoci
Copy link
Contributor

This PR is uncomplete and now is useless. Ref: #16618
@bmcstdio could you please close it?

@pierluigilenoci
Copy link
Contributor

/assign @olemarkus

@pierluigilenoci
Copy link
Contributor

#16656

@pierluigilenoci
Copy link
Contributor

@bmcstdio could you please close this?

@bmcustodio bmcustodio closed this Sep 2, 2019
@bmcustodio bmcustodio deleted the metrics-server-v0.3.3 branch September 2, 2019 07:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@olemarkus olemarkus olemarkus requested changes

@kennethaasan kennethaasan Awaiting requested review from kennethaasan

Assignees

@olemarkus olemarkus

Labels
Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). ok-to-test size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bmcustodio @k8s-ci-robot @olemarkus @pierluigilenoci @helm-bot