Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/metrics-server] #16060

Closed
wants to merge 5 commits into from
Closed

[stable/metrics-server] #16060

wants to merge 5 commits into from

Conversation

pierluigilenoci
Copy link
Contributor

@pierluigilenoci pierluigilenoci commented Aug 2, 2019 •
edited
Loading

What this PR does / why we need it:

Fix cluster roles for metrics-server. In this way metrics-server is able to list all namespaces.
Metrics-server version bump

Special notes for your reviewer:

Ref: kubernetes-sigs/metrics-server#293
Ref: kubernetes-sigs/metrics-server#296

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [stable/chart])

@helm-bot helm-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 2, 2019
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 2, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @PierluigiLenociAkelius. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Version bump and cluster-role fix
ecf65f7 
Signed-off-by: Pierluigi Lenoci <pierluigi.lenoci@akelius.de>
@helm-bot helm-bot added the Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). label Aug 2, 2019
This was referenced Aug 2, 2019
Merged
Closed
@helm-bot helm-bot removed the Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). label Aug 2, 2019
bumped too much
3863a88 
Signed-off-by: Pierluigi Lenoci <pierluigi.lenoci@akelius.de>
@helm-bot helm-bot added the Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). label Aug 2, 2019
@pierluigilenoci
Copy link
Contributor Author

/assign @olemarkus

@olemarkus
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 2, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: olemarkus, PierluigiLenociAkelius

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 2, 2019
@olemarkus
Copy link
Contributor

/retest

@mariomarin
Copy link

Please merge this pull request

@olemarkus
Copy link
Contributor

/retest

@davidkarlsen
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 8, 2019
@pierluigilenoci
Copy link
Contributor Author

/retest

@k8s-ci-robot
Copy link
Contributor

@PierluigiLenociAkelius: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-charts-e2e 3863a88 link /test pull-charts-e2e

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@pierluigilenoci
Copy link
Contributor Author

@olemarkus and now?

@olemarkus
Copy link
Contributor

Looks like metrics-server is not stopping properly. Not sure if that is related to the version bump. You could try splitting this PR in two

@pierluigilenoci
Copy link
Contributor Author

pierluigilenoci commented Aug 20, 2019 •
edited
Loading

We have a concurrent PR here: #15919

@olemarkus
Copy link
Contributor

We have a concurrent PR here: #15919

This one has some unresolved comments

@pierluigilenoci
Copy link
Contributor Author

@olemarkus I did it #16606

@pierluigilenoci pierluigilenoci mentioned this pull request Aug 27, 2019
Closed
4 tasks
@pierluigilenoci
Copy link
Contributor Author

I will close this because is useless. Ref: #16618 or #16606

@pierluigilenoci pierluigilenoci deleted the metrics-server branch August 27, 2019 11:33
@pierluigilenoci
Copy link
Contributor Author

#16654

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kennethaasan kennethaasan Awaiting requested review from kennethaasan

@olemarkus olemarkus Awaiting requested review from olemarkus

Assignees

@olemarkus olemarkus

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. ok-to-test size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@pierluigilenoci @k8s-ci-robot @olemarkus @mariomarin @davidkarlsen @helm-bot