Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/metrics-server] Bugfix / Add Missing Permissions #16618

Closed
wants to merge 3 commits into from
Closed

[stable/metrics-server] Bugfix / Add Missing Permissions #16618

wants to merge 3 commits into from

Conversation

bryantbiggs
Copy link

@bryantbiggs bryantbiggs commented Aug 26, 2019 •
edited
Loading

What this PR does / why we need it:

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [stable/chart])

@helm-bot helm-bot added the Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). label Aug 26, 2019
@helm-bot helm-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 26, 2019
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 26, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @bryantbiggs. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bryantbiggs
Bugfix / Add Missing Permissions
54b179e 
- Add namespace resource to cluster role resource permission
- Add nodes resource to aggregated reader cluster role permissions
- Bump image version to latest at 0.3.3

Signed-off-by: Bryant Biggs <bryantbiggs@gmail.com>
@pierluigilenoci
Copy link
Contributor

This PR is partially duplicated here: #16606 (without the metrics server version bump), partially here: #16060 (with metrics server version bump and half of the permissions) and partially here: #15919 (only with metrics server version bump).

@pierluigilenoci
Copy link
Contributor

/assign @olemarkus

@pierluigilenoci
Copy link
Contributor

If this PR build properly we can close all other PR related to metrics-server.

This was referenced Aug 27, 2019
Closed
Closed
@pierluigilenoci
Copy link
Contributor

@bryantbiggs could you please include in your PR this typo fix?

charts/stable/metrics-server/values.yaml

Line 26 in 4d456a5

# if you use Weave network on EKS
"netwok" -> "network"

@helm-bot helm-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). labels Aug 27, 2019
@bryantbiggs
- Correct typo mis-spelling
3392173 
Signed-off-by: Bryant Biggs <bryantbiggs@gmail.com>
@helm-bot helm-bot added the Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). label Aug 27, 2019
@bryantbiggs
Copy link
Author

@PierluigiLenociAkelius the typo correction has been added - thanks!

@pierluigilenoci
Copy link
Contributor

@bryantbiggs thank you too. I hope the test build is successful because the bump from 0.3.2 to 0.3.3 created some problems in my PR: #16060
For that reason I splitted the PR: #16606

@bryantbiggs
- Whitespace formatting, remove trailing blank lines
901d9ec 
Signed-off-by: Bryant Biggs <bryantbiggs@gmail.com>
@helm-bot helm-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 27, 2019
@olemarkus
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 27, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bryantbiggs, olemarkus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 27, 2019
@k8s-ci-robot
Copy link
Contributor

@bryantbiggs: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-charts-e2e 901d9ec link /test pull-charts-e2e

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@pierluigilenoci
Copy link
Contributor

@bryantbiggs as expected... the metrics-server bump break the build. :(

@olemarkus
Copy link
Contributor

I am curious if this is related to the bump or if this is due to a change in the test platform. It looks like it struggles to remove the deployment, but I don't see a diff locally. Would be good if #16514 was in a good state.

@pierluigilenoci
Copy link
Contributor

@olemarkus and what to fix this #16606?

@pierluigilenoci
Copy link
Contributor

Finally the permissions are fixed. #16654
@bryantbiggs now this is outdated. I'll create a new PR in order to have a PR to update the metrics-server version.

@pierluigilenoci
Copy link
Contributor

Created #16656

@pierluigilenoci
Copy link
Contributor

I'm ready also to create a PR for whitespace formatting and to remove trailing blank lines as suggested by @bryantbiggs
https://github.com/PierluigiLenociAkelius/charts/commit/a8bbdcbf2d9b29ba049dd11a369453669429dd66

@pierluigilenoci pierluigilenoci mentioned this pull request Aug 29, 2019
Merged
4 tasks
@bryantbiggs bryantbiggs deleted the bugfix/add-missing-permissions branch September 3, 2019 10:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kennethaasan kennethaasan Awaiting requested review from kennethaasan

@olemarkus olemarkus Awaiting requested review from olemarkus

Assignees

@olemarkus olemarkus

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bryantbiggs @k8s-ci-robot @pierluigilenoci @olemarkus @helm-bot