Rails 2, 3, and 4 LTS tests #1115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schneems
force-pushed
the
schneems/rails_lts
branch
from
270cfb1 to
c6a706d
Compare
The current Rails 3 LTS release does not work with Heroku Postgres and it makes a connection to the DB on boot, so I've deleted the Rakefile. Asserting behavior against the rest of the app is better than nothing. If it gets fixed from makandra later it can be re-visited.
schneems
force-pushed
the
schneems/rails_lts
branch
from
c6a706d to
e098a0b
Compare
schneems
force-pushed
the
schneems/rails_lts
branch
from
8bf7f9f to
7e824a4
Compare
schneems
force-pushed
the
schneems/rails_lts
branch
from
7e824a4 to
91efe24
Compare
|
Apparently my check changelog action isn't firing :( |
krisrang
added a commit
to skyltmax/heroku-buildpack-ruby
that referenced
this pull request
May 13, 2021
* upstream/main: (52 commits) Fix date (heroku#1152) Bundler 2.2.16 (heroku#1150) v226 (heroku#1149) [changelog skip] Remove Heroku-16 from tests: (heroku#1146) [close 1135] Update bundler 2.x to 2.2.15 (heroku#1144) [changelog skip] Clean up mime magic in repos (heroku#1145) Clean up CNB release process (heroku#1139) Use correct method name in script heroku#1129 (heroku#1129) Post-release updates: heroku/ruby 0.1.0 (heroku#1138) Add package.toml (heroku#1137) Add CNB release scripts (heroku#1136) Release v225 (heroku#1133) [close heroku#1126] Update bundler to 2.2.11 (heroku#1132) Update buildpack tests (heroku#1131) v224 (heroku#1128) Use jvm buildpack to install JRuby dependencies (heroku#1119) Fix YAML formatting (heroku#1116) Rails 2, 3, and 4 LTS tests (heroku#1115) v223 (heroku#1114) Fail detection with a CNB-friendly exit code (heroku#1112) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rails version support is limited by a few things:
Ruby version support
We only provide the latest non-EOL versions of Rubies on stacks. That means when cedar-14 went away, older versions of Ruby such as Ruby 1.9 are no longer available on the platform.
Rails library support by maintainers
We do not patch Rails versions. This includes not patching for security, and not patching for Ruby version compatibility. A customer's ability to run any given Rails version on the platform is limited by the version of Ruby that it can run on.
RailsLTS backports Ruby version compatibility to Rails 2, 3, and 4.
Behavior support in the Ruby buildpack
We will continue providing support for the behavior provided by the buildpack to Rails 2,3, and 4 customers provided. However we hit an issue where we could not run tests for these behaviors because the versions on Rubygems do not work with versions of Ruby available on current stacks.
To address this we're working with the RailsLTS team who have given us a license to use for our test suite. Now these versions of Rails can continue to be supported by Heroku maintainers along with tests for that behavior.