Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[changelog skip] Remove Heroku-16 from tests: #1146

Merged
merged 2 commits into from
Apr 12, 2021
Merged

[changelog skip] Remove Heroku-16 from tests: #1146

merged 2 commits into from
Apr 12, 2021

Conversation

schneems
Copy link
Contributor

@schneems schneems commented Apr 6, 2021 

Hatchet::App::FailedDeployError: Could not deploy 'hatchet-t-5e1aedd6a2' (default_ruby) using 'Hatchet::GitApp' at path: 'test/fixtures/repos/ruby/default_ruby'
if this was expected add `allow_failure: true` to your deploy hash.
Buildpack: nil
Repo: https://git.heroku.com/hatchet-t-5e1aedd6a2.git
output:
remote: Compressing source files... done.
remote: Building source:
remote:
remote: !   Your app is using the Heroku-16 stack, which will be end-of-life on May 1st, 2021.
remote: !
remote: !   Builds on Heroku-16 will not be possible from June 1st, 2021.
remote: !
remote: !   Please upgrade the stack of your app as soon as possible:
remote: !   https://devcenter.heroku.com/articles/upgrading-to-the-latest-stack
remote: !
remote: !   Heroku-16 EOL FAQ: https://help.heroku.com/0S5P41DC/heroku-16-end-of-life-faq
remote: !
remote: !   THIS IS A ONE-OFF NOTICE. THE NEXT DEPLOY WILL FUNCTION WITHOUT INTERRUPTION.
remote: !
remote: !   The next warning of this kind will occur in: 7 day(s).
remote:
To https://git.heroku.com/hatchet-t-5e1aedd6a2.git
Collapse

@schneems
[changelog skip] Remove Heroku-16 from tests:
00edb9e 
```
Hatchet::App::FailedDeployError: Could not deploy 'hatchet-t-5e1aedd6a2' (default_ruby) using 'Hatchet::GitApp' at path: 'test/fixtures/repos/ruby/default_ruby'
if this was expected add `allow_failure: true` to your deploy hash.
Buildpack: nil
Repo: https://git.heroku.com/hatchet-t-5e1aedd6a2.git
output:
remote: Compressing source files... done.
remote: Building source:
remote:
remote: !   Your app is using the Heroku-16 stack, which will be end-of-life on May 1st, 2021.
remote: !
remote: !   Builds on Heroku-16 will not be possible from June 1st, 2021.
remote: !
remote: !   Please upgrade the stack of your app as soon as possible:
remote: !   https://devcenter.heroku.com/articles/upgrading-to-the-latest-stack
remote: !
remote: !   Heroku-16 EOL FAQ: https://help.heroku.com/0S5P41DC/heroku-16-end-of-life-faq
remote: !
remote: !   THIS IS A ONE-OFF NOTICE. THE NEXT DEPLOY WILL FUNCTION WITHOUT INTERRUPTION.
remote: !
remote: !   The next warning of this kind will occur in: 7 day(s).
remote:
To https://git.heroku.com/hatchet-t-5e1aedd6a2.git
Collapse
```
@schneems schneems marked this pull request as ready for review April 6, 2021 19:50
@schneems schneems requested a review from a team as a code owner April 6, 2021 19:50
@schneems schneems merged commit 5ac7099 into main Apr 12, 2021
@schneems schneems deleted the schneems/rm-rf-heroku-16 branch April 12, 2021 15:37
krisrang added a commit to skyltmax/heroku-buildpack-ruby that referenced this pull request May 13, 2021
@krisrang
Merge remote-tracking branch 'upstream/main'
c5894e2 
* upstream/main: (52 commits)
  Fix date (heroku#1152)
  Bundler 2.2.16 (heroku#1150)
  v226 (heroku#1149)
  [changelog skip] Remove Heroku-16 from tests: (heroku#1146)
  [close 1135] Update bundler 2.x to 2.2.15 (heroku#1144)
  [changelog skip] Clean up mime magic in repos (heroku#1145)
  Clean up CNB release process (heroku#1139)
  Use correct method name in script heroku#1129 (heroku#1129)
  Post-release updates: heroku/ruby 0.1.0 (heroku#1138)
  Add package.toml (heroku#1137)
  Add CNB release scripts (heroku#1136)
  Release v225 (heroku#1133)
  [close heroku#1126] Update bundler to 2.2.11 (heroku#1132)
  Update buildpack tests (heroku#1131)
  v224 (heroku#1128)
  Use jvm buildpack to install JRuby dependencies (heroku#1119)
  Fix YAML formatting (heroku#1116)
  Rails 2, 3, and 4 LTS tests (heroku#1115)
  v223 (heroku#1114)
  Fail detection with a CNB-friendly exit code (heroku#1112)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edmorley edmorley edmorley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@schneems @edmorley