Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[changelog skip] Update buildpack tests #1131

Merged
merged 1 commit into from
Feb 25, 2021
Merged

[changelog skip] Update buildpack tests #1131

merged 1 commit into from
Feb 25, 2021

Conversation

schneems
Copy link
Contributor

The heroku-16 stack is deprecated. With heroku-20 tests were failing:

-----> Building on the Heroku-20 stack
-----> Fetching https://github.com/heroku/heroku-buildpack-cli.git buildpack...
       buildpack downloaded
-----> Fetching https://github.com/heroku/heroku-buildpack-ruby#v211 buildpack...
       buildpack downloaded
-----> heroku-cli app detected
=== Fetching and vendoring Heroku CLI into slug
=== Installing profile.d script
 ›   Warning: Our terms of service have changed:
 ›   https://dashboard.heroku.com/terms-of-service
heroku/7.49.0 linux-x64 node-v12.16.2
=== Heroku CLI installation done
-----> Ruby app detected
  Failed to download a Ruby executable for bootstrapping!
  This is most likely a temporary internal error. If the problem
  persists, make sure that you are not running a custom or forked
  version of the Heroku Ruby buildpack which may need updating.
/tmp/buildpacks/b2f3365577702f34ed6e4203939f02452cc3ab33/bin/test-compile: line 11: /tmp/tmp.KitelDjTSM/bin/ruby: No such file or directory

This commit ensures we're testing against the latest buildpack release instead of a very old tag. In addition, we're dropping building cedar-14 and adding the download url to the above error message.

The heroku-16 stack is deprecated. With heroku-20 tests were failing:

```

-----> Building on the Heroku-20 stack

-----> Fetching https://github.com/heroku/heroku-buildpack-cli.git buildpack...

       buildpack downloaded

-----> Fetching https://github.com/heroku/heroku-buildpack-ruby#v211 buildpack...

       buildpack downloaded

-----> heroku-cli app detected

=== Fetching and vendoring Heroku CLI into slug

=== Installing profile.d script

 ›   Warning: Our terms of service have changed:

 ›   https://dashboard.heroku.com/terms-of-service

heroku/7.49.0 linux-x64 node-v12.16.2

=== Heroku CLI installation done

-----> Ruby app detected

  Failed to download a Ruby executable for bootstrapping!

  This is most likely a temporary internal error. If the problem

  persists, make sure that you are not running a custom or forked

  version of the Heroku Ruby buildpack which may need updating.

/tmp/buildpacks/b2f3365577702f34ed6e4203939f02452cc3ab33/bin/test-compile: line 11: /tmp/tmp.KitelDjTSM/bin/ruby: No such file or directory
```

This commit ensures we're testing against the latest buildpack release instead of a very old tag. In addition, we're dropping building cedar-14 and adding the download url to the above error message.
@schneems schneems changed the title Update buildpack tests [changelog skip] Update buildpack tests Feb 25, 2021
@schneems schneems marked this pull request as ready for review February 25, 2021 16:30
@schneems schneems requested a review from a team as a code owner February 25, 2021 16:30
@schneems schneems merged commit 1890086 into main Feb 25, 2021
@schneems schneems deleted the schneems/fix-tests branch February 25, 2021 16:31
krisrang added a commit to skyltmax/heroku-buildpack-ruby that referenced this pull request May 13, 2021
* upstream/main: (52 commits)
  Fix date (heroku#1152)
  Bundler 2.2.16 (heroku#1150)
  v226 (heroku#1149)
  [changelog skip] Remove Heroku-16 from tests: (heroku#1146)
  [close 1135] Update bundler 2.x to 2.2.15 (heroku#1144)
  [changelog skip] Clean up mime magic in repos (heroku#1145)
  Clean up CNB release process (heroku#1139)
  Use correct method name in script heroku#1129 (heroku#1129)
  Post-release updates: heroku/ruby 0.1.0 (heroku#1138)
  Add package.toml (heroku#1137)
  Add CNB release scripts (heroku#1136)
  Release v225 (heroku#1133)
  [close heroku#1126] Update bundler to 2.2.11 (heroku#1132)
  Update buildpack tests (heroku#1131)
  v224 (heroku#1128)
  Use jvm buildpack to install JRuby dependencies (heroku#1119)
  Fix YAML formatting (heroku#1116)
  Rails 2, 3, and 4 LTS tests (heroku#1115)
  v223 (heroku#1114)
  Fail detection with a CNB-friendly exit code (heroku#1112)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants