Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix reauth flow for Comelit VEDO #107461

Merged
merged 3 commits into from
Jan 12, 2024
Merged

Fix reauth flow for Comelit VEDO #107461

merged 3 commits into from
Jan 12, 2024

Conversation

chemelli74
Copy link
Contributor

Breaking change

Proposed change

Fix reauth flow for Comelit VEDO

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@chemelli74 chemelli74 added this to the 2024.1.3 milestone Jan 7, 2024
frenck
frenck approved these changes Jan 12, 2024
View reviewed changes
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @chemelli74 👍

../Frenck

@frenck frenck merged commit 8d5cdfa into home-assistant:dev Jan 12, 2024
23 checks passed
@chemelli74 chemelli74 deleted the chemelli74-comelit-flow branch January 12, 2024 11:39
frenck pushed a commit that referenced this pull request Jan 12, 2024
@chemelli74 @frenck
Fix reauth flow for Comelit VEDO (#107461)
8682201
@frenck frenck mentioned this pull request Jan 12, 2024
Merged
nrdufour added a commit to nrdufour/home-ops that referenced this pull request Jan 13, 2024
@nrdufour
chore(deps): update ghcr.io/home-assistant/home-assistant docker tag …
70800e9 
…to v2024.1.3 (#305)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [ghcr.io/home-assistant/home-assistant](https://www.home-assistant.io/) ([source](https://github.com/home-assistant/core)) | patch | `2024.1.2` -> `2024.1.3` |

---

### Release Notes

<details>
<summary>home-assistant/core (ghcr.io/home-assistant/home-assistant)</summary>

### [`v2024.1.3`](https://github.com/home-assistant/core/releases/tag/2024.1.3)

[Compare Source](home-assistant/core@2024.1.2...2024.1.3)

-   Add diagnostics to A. O. Smith integration ([@&#8203;bdr99] - [#&#8203;106343]) ([aosmith docs])
-   Catch missing inverter in Enphase Envoy ([@&#8203;catsmanac] - [#&#8203;106730]) ([enphase_envoy docs])
-   Prevent toggle from calling stop on covers which do not support it ([@&#8203;vexofp] - [#&#8203;106848]) ([cover docs])
-   Fix missing unique_id for spt integration ([@&#8203;miaucl] - [#&#8203;107087]) ([swiss_public_transport docs])
-   Add support for the Spotify DJ ([@&#8203;BTMorton] - [#&#8203;107268]) ([spotify docs])
-   Fix evohome high_precision temps not retreived consistently ([@&#8203;zxdavb] - [#&#8203;107366]) ([evohome docs])
-   Reduce polling rate in Blink ([@&#8203;mkmer] - [#&#8203;107386]) ([blink docs])
-   Fix KNX telegram device trigger not firing after integration reload ([@&#8203;farmio] - [#&#8203;107388]) ([knx docs])
-   Fix language flavors in holiday ([@&#8203;gjohansson-ST] - [#&#8203;107392]) ([holiday docs])
-   Handle OSError during setup for System Monitor ([@&#8203;gjohansson-ST] - [#&#8203;107396]) ([systemmonitor docs])
-   Remove name from faa_delays ([@&#8203;joostlek] - [#&#8203;107418]) ([faa_delays docs])
-   Fix Swiss public transport initial data for attributes ([@&#8203;miaucl] - [#&#8203;107452]) ([swiss_public_transport docs])
-   Fix reauth flow for Comelit VEDO ([@&#8203;chemelli74] - [#&#8203;107461]) ([comelit docs])
-   Fix asyncio.gather call ([@&#8203;cdce8p] - [#&#8203;107500]) ([microsoft_face docs])
-   Fix Luftdaten sensor id string ([@&#8203;mrueg] - [#&#8203;107506]) ([luftdaten docs])
-   Bump zm-py version to v0.5.3 for zoneminder ([@&#8203;nabbi] - [#&#8203;107331]) ([zoneminder docs]) (dependency)
-   Retry zoneminder connection setup ([@&#8203;nabbi] - [#&#8203;107519]) ([zoneminder docs]) (dependency)
-   Don't include position in binary valve attributes ([@&#8203;emontnemery] - [#&#8203;107531]) ([valve docs])
-   Bump blinkpy to 0.22.5 ([@&#8203;mkmer] - [#&#8203;107537]) ([blink docs])
-   Bump reolink_aio to 0.8.6 ([@&#8203;starkillerOG] - [#&#8203;107541]) ([reolink docs]) (dependency)
-   Bump mcstatus to v11.1.1 ([@&#8203;elmurato] - [#&#8203;107546]) ([minecraft_server docs]) (dependency)
-   Bump aioshelly to 7.1.0 ([@&#8203;thecode] - [#&#8203;107593]) ([shelly docs]) (dependency)
-   Fix Tado unique mobile device dispatcher ([@&#8203;erwindouna] - [#&#8203;107631]) ([tado docs])
-   Fix tplink_lte setup ([@&#8203;cdce8p] - [#&#8203;107642]) ([tplink_lte docs])
-   Prevent overriding cached attribute as property ([@&#8203;emontnemery] - [#&#8203;107657])
-   Set max and min temp for flexit_bacnet climate entity ([@&#8203;lellky] - [#&#8203;107665]) ([flexit_bacnet docs])
-   Fix duplicated resource issue in System Monitor ([@&#8203;gjohansson-ST] - [#&#8203;107671]) ([systemmonitor docs])
-   Fix invalid alexa climate or water_heater state report with double listed targetSetpoint ([@&#8203;jbouwh] - [#&#8203;107673]) ([alexa docs])
-   Redact sensitive data in alexa debug logging ([@&#8203;jbouwh] - [#&#8203;107676]) ([alexa docs])
-   Fix `device_class` type for Shelly Gen1 sleeping sensors ([@&#8203;bieniu] - [#&#8203;107683]) ([shelly docs])
-   Clamp tplink color temp to valid range ([@&#8203;bdraco] - [#&#8203;107695]) ([tplink docs])
-   Fix cloud tts loading ([@&#8203;MartinHjelmare] - [#&#8203;107714]) ([cloud docs])
-   Allow configuration of min_gradient from UI to be negative in Trend ([@&#8203;jpbede] - [#&#8203;107720]) ([trend docs])
-   Bump aioswitcher to 3.4.1 ([@&#8203;YogevBokobza] - [#&#8203;107730]) ([switcher_kis docs])
-   Fix mqtt text text min max config params can not be equal ([@&#8203;jbouwh] - [#&#8203;107738]) ([mqtt docs])
-   Fix "not-logged" edge cases for Comelit VEDO ([@&#8203;chemelli74] - [#&#8203;107741]) ([comelit docs]) (dependency)
-   Fix Mac address check in kef integration ([@&#8203;eugenet8k] - [#&#8203;107746]) ([kef docs])
-   Fix ld2410\_ble not being able to setup because it has a stale connection ([@&#8203;bdraco] - [#&#8203;107754]) ([ld2410\_ble docs][ld2410_ble docs])
-   Bump pyunifiprotect to 4.23.1 ([@&#8203;AngellusMortis] - [#&#8203;107758]) ([unifiprotect docs]) (dependency)
-   Bump pyunifiprotect to 4.23.2 ([@&#8203;AngellusMortis] - [#&#8203;107769]) ([unifiprotect docs]) (dependency)
-   Rework events for UniFi Protect ([@&#8203;AngellusMortis] - [#&#8203;107771]) ([unifiprotect docs])
-   Fix switcher kis logging incorrect property for device's name ([@&#8203;idofl] - [#&#8203;107775]) ([switcher_kis docs])
-   Bump bluetooth deps ([@&#8203;bdraco] - [#&#8203;107816]) ([bluetooth docs]) (dependency)
-   Fix Tailwind cover stuck in closing state ([@&#8203;frenck] - [#&#8203;107827]) ([tailwind docs])
-   Fix for exception in screenlogic.set_color_mode ([@&#8203;dieselrabbit] - [#&#8203;107850]) ([screenlogic docs])
-   Bump aio_geojson_generic_client to 0.4 ([@&#8203;exxamalte] - [#&#8203;107866]) ([geo_json_events docs]) (dependency)

[#&#8203;106343]: home-assistant/core#106343

[#&#8203;106730]: home-assistant/core#106730

[#&#8203;106848]: home-assistant/core#106848

[#&#8203;106970]: home-assistant/core#106970

[#&#8203;107087]: home-assistant/core#107087

[#&#8203;107239]: home-assistant/core#107239

[#&#8203;107268]: home-assistant/core#107268

[#&#8203;107331]: home-assistant/core#107331

[#&#8203;107365]: home-assistant/core#107365

[#&#8203;107366]: home-assistant/core#107366

[#&#8203;107386]: home-assistant/core#107386

[#&#8203;107388]: home-assistant/core#107388

[#&#8203;107392]: home-assistant/core#107392

[#&#8203;107396]: home-assistant/core#107396

[#&#8203;107418]: home-assistant/core#107418

[#&#8203;107452]: home-assistant/core#107452

[#&#8203;107461]: home-assistant/core#107461

[#&#8203;107500]: home-assistant/core#107500

[#&#8203;107506]: home-assistant/core#107506

[#&#8203;107519]: home-assistant/core#107519

[#&#8203;107531]: home-assistant/core#107531

[#&#8203;107537]: home-assistant/core#107537

[#&#8203;107541]: home-assistant/core#107541

[#&#8203;107546]: home-assistant/core#107546

[#&#8203;107593]: home-assistant/core#107593

[#&#8203;107631]: home-assistant/core#107631

[#&#8203;107642]: home-assistant/core#107642

[#&#8203;107657]: home-assistant/core#107657

[#&#8203;107665]: home-assistant/core#107665

[#&#8203;107671]: home-assistant/core#107671

[#&#8203;107673]: home-assistant/core#107673

[#&#8203;107676]: home-assistant/core#107676

[#&#8203;107683]: home-assistant/core#107683

[#&#8203;107695]: home-assistant/core#107695

[#&#8203;107714]: home-assistant/core#107714

[#&#8203;107720]: home-assistant/core#107720

[#&#8203;107730]: home-assistant/core#107730

[#&#8203;107738]: home-assistant/core#107738

[#&#8203;107741]: home-assistant/core#107741

[#&#8203;107746]: home-assistant/core#107746

[#&#8203;107754]: home-assistant/core#107754

[#&#8203;107758]: home-assistant/core#107758

[#&#8203;107769]: home-assistant/core#107769

[#&#8203;107771]: home-assistant/core#107771

[#&#8203;107775]: home-assistant/core#107775

[#&#8203;107816]: home-assistant/core#107816

[#&#8203;107827]: home-assistant/core#107827

[#&#8203;107850]: home-assistant/core#107850

[#&#8203;107866]: home-assistant/core#107866

[@&#8203;AngellusMortis]: https://github.com/AngellusMortis

[@&#8203;BTMorton]: https://github.com/BTMorton

[@&#8203;MartinHjelmare]: https://github.com/MartinHjelmare

[@&#8203;YogevBokobza]: https://github.com/YogevBokobza

[@&#8203;bdr99]: https://github.com/bdr99

[@&#8203;bdraco]: https://github.com/bdraco

[@&#8203;bieniu]: https://github.com/bieniu

[@&#8203;catsmanac]: https://github.com/catsmanac

[@&#8203;cdce8p]: https://github.com/cdce8p

[@&#8203;chemelli74]: https://github.com/chemelli74

[@&#8203;dieselrabbit]: https://github.com/dieselrabbit

[@&#8203;elmurato]: https://github.com/elmurato

[@&#8203;emontnemery]: https://github.com/emontnemery

[@&#8203;erwindouna]: https://github.com/erwindouna

[@&#8203;eugenet8k]: https://github.com/eugenet8k

[@&#8203;exxamalte]: https://github.com/exxamalte

[@&#8203;farmio]: https://github.com/farmio

[@&#8203;frenck]: https://github.com/frenck

[@&#8203;gjohansson-ST]: https://github.com/gjohansson-ST

[@&#8203;idofl]: https://github.com/idofl

[@&#8203;jbouwh]: https://github.com/jbouwh

[@&#8203;joostlek]: https://github.com/joostlek

[@&#8203;jpbede]: https://github.com/jpbede

[@&#8203;lellky]: https://github.com/lellky

[@&#8203;miaucl]: https://github.com/miaucl

[@&#8203;mkmer]: https://github.com/mkmer

[@&#8203;mrueg]: https://github.com/mrueg

[@&#8203;nabbi]: https://github.com/nabbi

[@&#8203;starkillerOG]: https://github.com/starkillerOG

[@&#8203;thecode]: https://github.com/thecode

[@&#8203;vexofp]: https://github.com/vexofp

[@&#8203;zxdavb]: https://github.com/zxdavb

[alexa docs]: https://www.home-assistant.io/integrations/alexa/

[aosmith docs]: https://www.home-assistant.io/integrations/aosmith/

[blink docs]: https://www.home-assistant.io/integrations/blink/

[bluetooth docs]: https://www.home-assistant.io/integrations/bluetooth/

[cloud docs]: https://www.home-assistant.io/integrations/cloud/

[comelit docs]: https://www.home-assistant.io/integrations/comelit/

[cover docs]: https://www.home-assistant.io/integrations/cover/

[enigma2 docs]: https://www.home-assistant.io/integrations/enigma2/

[enphase_envoy docs]: https://www.home-assistant.io/integrations/enphase_envoy/

[evohome docs]: https://www.home-assistant.io/integrations/evohome/

[faa_delays docs]: https://www.home-assistant.io/integrations/faa_delays/

[flexit_bacnet docs]: https://www.home-assistant.io/integrations/flexit_bacnet/

[geo_json_events docs]: https://www.home-assistant.io/integrations/geo_json_events/

[holiday docs]: https://www.home-assistant.io/integrations/holiday/

[kef docs]: https://www.home-assistant.io/integrations/kef/

[knx docs]: https://www.home-assistant.io/integrations/knx/

[ld2410_ble docs]: https://www.home-assistant.io/integrations/ld2410_ble/

[luftdaten docs]: https://www.home-assistant.io/integrations/luftdaten/

[microsoft_face docs]: https://www.home-assistant.io/integrations/microsoft_face/

[minecraft_server docs]: https://www.home-assistant.io/integrations/minecraft_server/

[mqtt docs]: https://www.home-assistant.io/integrations/mqtt/

[reolink docs]: https://www.home-assistant.io/integrations/reolink/

[screenlogic docs]: https://www.home-assistant.io/integrations/screenlogic/

[shelly docs]: https://www.home-assistant.io/integrations/shelly/

[spotify docs]: https://www.home-assistant.io/integrations/spotify/

[streamlabswater docs]: https://www.home-assistant.io/integrations/streamlabswater/

[swiss_public_transport docs]: https://www.home-assistant.io/integrations/swiss_public_transport/

[switcher_kis docs]: https://www.home-assistant.io/integrations/switcher_kis/

[system_bridge docs]: https://www.home-assistant.io/integrations/system_bridge/

[systemmonitor docs]: https://www.home-assistant.io/integrations/systemmonitor/

[tado docs]: https://www.home-assistant.io/integrations/tado/

[tailwind docs]: https://www.home-assistant.io/integrations/tailwind/

[tplink docs]: https://www.home-assistant.io/integrations/tplink/

[tplink_lte docs]: https://www.home-assistant.io/integrations/tplink_lte/

[trend docs]: https://www.home-assistant.io/integrations/trend/

[unifiprotect docs]: https://www.home-assistant.io/integrations/unifiprotect/

[valve docs]: https://www.home-assistant.io/integrations/valve/

[zha docs]: https://www.home-assistant.io/integrations/zha/

[zoneminder docs]: https://www.home-assistant.io/integrations/zoneminder/

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about these updates again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMjkuMSIsInVwZGF0ZWRJblZlciI6IjM3LjEyOS4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Reviewed-on: https://git.home/nrdufour/home-ops/pulls/305
Co-authored-by: Renovate <renovate@ptinem.io>
Co-committed-by: Renovate <renovate@ptinem.io>
@github-actions github-actions bot locked and limited conversation to collaborators Jan 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@frenck frenck frenck approved these changes

Assignees
No one assigned
Labels
bugfix by-code-owner cherry-picked cla-signed integration: comelit Quality Scale: No score small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
2024.1.3
Development

Successfully merging this pull request may close these issues.
2 participants
@chemelli74 @frenck