Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Toca Race Driver 2 (Guardband glitch again) #15049

Closed
5 tasks done
MiguelCardonaG opened this issue Oct 23, 2021 · 26 comments · Fixed by #16645
Closed
5 tasks done

Toca Race Driver 2 (Guardband glitch again) #15049

MiguelCardonaG opened this issue Oct 23, 2021 · 26 comments · Fixed by #16645
Labels
Guardband / Range Culling Involves vertices outside fustrum. Mali GPU
Milestone
v1.14.2

Comments

@MiguelCardonaG
Copy link

Game or games this happens in

ULES-00040 - Toca Race Driver 2

What area of the game / PPSSPP

When starting a race.

PPSSPP_2021-10-23-13-23-13

#11999

What should happen

In version 68 there is no on-screen error.

Logs

No response

Platform

Android

Mobile phone model or graphics card

Samsung Galaxy Note 10 plus exynos

PPSSPP version affected

ppsspp-v1.12.3-74-g7d94f3777-android.apk

Last working version

ppsspp-v1.12.3-68-g4bd4cde4a-android.apk

Graphics backend (3D API)

OpenGL / GLES

Checklist

  • Test in the latest git build in case it's already fixed.
  • Search for other reports of the same issue.
  • Try resetting settings or older versions and include if the issue is related.
  • Try without any cheats and without loading any save states.
  • Include logs or screenshots of issue.
@ghost
Copy link

ghost commented Oct 23, 2021

Yes this is a regression, I can reproduce this issue both opengl and vulkan in my phone rn9.

Here's the dump.
toca_race_2_dump.ppdmp.zip

@ghost
Copy link

ghost commented Oct 23, 2021

This issue is back #5001 @unknownbrackets

unknownbrackets added a commit to unknownbrackets/ppsspp that referenced this issue Oct 23, 2021
@unknownbrackets
GPU: Allow range cull on Mali/etc.
c81c9fd 
Previously had been disabled when cullDistance/clipDistnance were
unsupported, but it's still helpful without those.  See hrydgard#15049.
unknownbrackets added a commit to unknownbrackets/ppsspp that referenced this issue Oct 23, 2021
@unknownbrackets
GPU: Allow range cull on Mali/etc.
5557950 
Previously had been disabled when cullDistance/clipDistance were
unsupported, but it's still helpful without those.  See hrydgard#15049.
@unknownbrackets unknownbrackets mentioned this issue Oct 23, 2021
Merged
@unknownbrackets unknownbrackets added this to the v1.13.0 milestone Oct 23, 2021
@unknownbrackets
Copy link
Collaborator

Sorry, have had spotty time recently and really screwed up that conditional. Restored range culling for Mali and other devices that don't support shader culling. Is it working now?

-[Unknown]

@hrydgard hrydgard added the Guardband / Range Culling Involves vertices outside fustrum. label Oct 23, 2021
@hrydgard
Copy link
Owner

(also my fault for screwing up the review of the check...)

Will work on a geometry shader solution for Mali soon, we'll see if it performs well enough to enable generically.

@ghost
Copy link

ghost commented Oct 23, 2021

Confirm fixed by 067f45d

@MiguelCardonaG
Copy link
Author

I confirm, it works well!! 😃👍

@ThePhoenixRises
Copy link

ThePhoenixRises commented Dec 19, 2022 •
edited
Loading

Hi Developers,
Seems this games banding problem is back from 1.14.04 - Happens on Vulkan or Open GL es - (Please note this doesn't happen on the Windows build, Vulkan etc etc).
photo_2022-12-18_19-48-41
This is on a Retroid Pocket 3+ with these system specs...............

photo_2022-12-18_22-09-59
photo_2022-12-18_22-11-17

@unknownbrackets
Copy link
Collaborator

Are you sure you're using v1.14.0? Is this with software transform on or off? Does it change anything?

You said it did and did not happen on Vulkan, maybe you meant it doesn't happen on Windows + Vulkan.

-[Unknown]

@ThePhoenixRises
Copy link

No sorry Unknown, i meant this seems to be only a problem on Android, using that version 1.14.0.

@ghost
Copy link

ghost commented Dec 21, 2022

No sorry Unknown, i meant this seems to be only a problem on Android, using that version 1.14.0.

Did you enable geometry culling in graphics setting?

@hrydgard
Copy link
Owner

Geometry-shader culling should not be needed for this issue, the vertes-shader based range culling should be enough.

@ghost
Copy link

ghost commented Dec 21, 2022 via email

@ThePhoenixRises
Copy link

ThePhoenixRises commented Dec 22, 2022 •
edited
Loading

Hi sorry, i was a bit busy, but no culling is on, just trying 1.14.1-8 to see if any change.
Nope no luck, same problem guys, banding is still there.

@ghost
Copy link

ghost commented Dec 22, 2022 via email

@ghost
Copy link

ghost commented Dec 22, 2022

I cannot reproduce this issue in my vivo y11 vulkan backend and I also notice that this game performance is decrease.
Screenshot_20221222_124730_2f85358b2198d26f8aca533d68bee793

@MiguelCardonaG
Copy link
Author

Yes, I confirm that it fails again.

Screenshot_20221222-111347_PPSSPP

Screenshot_20221222-111219_PPSSPP

Screenshot_20221222-111343_PPSSPP

Samsung Galaxy Note 10 plus exynos. Android 12. ppsspp-v1.14.1-9-gf65a8aa74-android

@hrydgard
Copy link
Owner

I will look into this.

@hrydgard hrydgard reopened this Dec 22, 2022
@hrydgard hrydgard modified the milestones: v1.13.0, v1.14.2 Dec 22, 2022
@ghost
Copy link

ghost commented Dec 22, 2022

Safe to tag as MALI GPU issue only?

@hrydgard
Copy link
Owner

I believe what's happening is that we now prefer the geometry shader path to fix this on Mali, but if that's turned off, we just don't do anything, instead of using the vertex shader method. Should be easy to fix.

@ghost
Copy link

ghost commented Dec 22, 2022

I cannot reproduce this issue in my vivo y11 vulkan backend and I also notice that this game performance is decrease. Screenshot_20221222_124730_2f85358b2198d26f8aca533d68bee793

About the performance skip gpu readbacks should be on.

@hrydgard hrydgard mentioned this issue Dec 22, 2022
Merged
@ThePhoenixRises
Copy link

Thanks guys, this now runs perfect again, using Android 11 on my Retroid Pocket 3+ with its annoying Mali GPU, but somehow runs this game at 2 x texture upscaled, plus 2 x hardware scaled, and plays at a solid 40 fps.
Fantastic emulator, on this awesome handheld, for its price.
Toca Race Driver 2

@ghost ghost mentioned this issue Jan 3, 2023
Closed
5 tasks
@Duglor
Copy link

Duglor commented Jun 10, 2024

This is occuring in the latest version of PPSSPP for Toca Racer 2 and 3 for the RetroPie 4.X. Is there a setting in the lr-ppsspp or the standalone ppsspp that should be changed to fix this guardband glitch?

@hrydgard
Copy link
Owner

Did you turn on the speedhack "Disable culling"?

@Duglor
Copy link

Duglor commented Oct 10, 2024

Did you turn on the speedhack "Disable culling"?

Yes

@hrydgard
Copy link
Owner

Well then turn it off. It's not compatible with this game

@Duglor
Copy link

Duglor commented Oct 11, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Guardband / Range Culling Involves vertices outside fustrum. Mali GPU
Projects
None yet
Milestone
v1.14.2
Development

Successfully merging a pull request may close this issue.

Fix vertex shader range culling - the driver bug check was wrong. hrydgard/ppsspp
5 participants
@hrydgard @unknownbrackets @ThePhoenixRises @Duglor @MiguelCardonaG