a proper branch for fixing issues of sceMp3 #5828
Conversation
kaienfr
commented
Apr 10, 2014
kaienfr
commented
- The voice speed issue (eg. "Hanayaka Nari Wa ga Ichizoku" Hanayaka Nari Wa ga Ichizoku strange MP3 mono voice #5213) should be ok.
- Downstream Panic is all right.
- Improve ffmpeg callback function to correctly control loops and buffer copies.
1. The voice speed issue (eg. "Hanayaka Nari Wa ga Ichizoku" hrydgard#5213) should be ok. 2. Downstream Panic is all right. 3. Improve ffmpeg callback function to correctly control loops and buffer copies.
Based on this commit hrydgard#5828 on improvements to sceMp3 Custom BGM can be update now. Test on "Miku" is just all right :)
For some sound issue hacks. Currently, I add two hacks 1. Mp3 Sample Rate fixed to 44100Hz ( fixing fast voice issue) 2. Fix mp3 loop issues (fixing Miku custom mp3 playing issue, and lost last voice issue) Provide some sound hacks seem necessary since we have many issues hard to fix and can not working both with previous settings simultaneously.
|
I add two sound hacks menu for providing some sound hacks, this seem necessary since we have many issues hard to be fixed and can not working both with previous settings simultaneously.
The setting UI is like this: |
| } | ||
| __AdjustBGMVolume((s16 *)out, frame.nb_samples * frame.channels); | ||
| // always convert to stereo pcm | ||
| __AdjustBGMVolume((s16 *)out, frame->nb_samples * 2); |
There was a problem hiding this comment.
Instead of just blindly multiplying by 2 it would make the code clearer to do this:
int num_channels = 2;
__AdjustBGMVolume((s16 *)out, frame->nb_samples * num_channels);
and later below
bytespcm += ret * sizeof(s16) * num_channels;
There was a problem hiding this comment.
ok, I will add this
|
Here it is. |
|
@hrydgard Please look at the above two commits and tell me do you agree such changes. It will only affect 48kHz 1152 sampleCount audios (no matter mono or stereo), such as mp3 and wma. Tests on Miku 48000 Hz mp3 and Hanayaka Nari Wa ga Ichizoku 32000Hz mp3 are both all right. |
|
Hmmmm. We avoid two sample rate conversion at the cost of operating entirely unlike what the PSP is doing, which seems dangerous. I'll look at it some more but I don't think I like it... |
|
I will close this one, since the universal audio branch seems much better #5839 |
