Custom BGM is fixed

[kaienfr]

Based on this commit #5828 on improvements to sceMp3
Custom BGM can be update now. Test on "Miku" is just all right :)

[kaienfr]

Add a new audio hack menu in #5828 we can chose to active or not the new setting to prevent possibly other unknown sound issues.

[hrydgard]

As previously discussed, a partial memcpy is not the correct way to shorten filenames according to FAT32 rules - but on the other hand this is really rarely-used functionality and it hardly matters - the game will just use the short name as an internal identifier anyway. So I'll let it slide for now and possibly revisit later.

[kaienfr]

Ok, let's look and see others feedback if we need something more to do.

[unknownbrackets]

Well, and the strncpy() still copies 256 bytes always. I hate it when there's comments like this:

// Copy 10 bytes.
memcpy(dst, src, 20);

Which is exactly how this looks to me.

-[Unknown]

[kaienfr]

We could copy in a right order, copy the short part before the long part.
for example, we copy the 8.3 name first even it occupied 256 bytes (anyway it will not longer than the length of sortname+full path), then we copy the full path from the position we need.

[hrydgard]

Agh, forgot the extralong strncpy thing. That's the danger of re-opening pullrqs, losing comments...

[Fei-Lix]

there is one of my mp3 was Star Story BGM shows this message:

also other custom BGM gives no sounds like Kagerou Daze BGM, I'll provide these samples here (includes Edit data + MP3 of Star Story and Kagerou Daze): mediafire.com/?bluz77oz6752wtz
Password is "no sound"

[kaienfr]

@RinkuFO This is only a part of update, since its completely another issue in show cunstom menu, so we separate it from our universal audio branch, only with the later one, you can play Miku. But it still not been merged yet. #5839

Miku issue is already perfectly solved there.

[Fei-Lix]

@kaienfr ohhh I see, sorry I didn't noticed it because I've been excited to test it out