Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

John conroy/fix url sync #2909

Merged
merged 7 commits into from
Sep 22, 2022
Merged

John conroy/fix url sync #2909

merged 7 commits into from
Sep 22, 2022

Conversation

john-conroy
Copy link
Collaborator

Fix #2899.

Copy link
Contributor

@mccalluc mccalluc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about one catch, but otherwise looks good.

I can't reproduce the original bug on this branch, but there is some other weird behavior... not necessarily bugs, but does intersect with URL state.

  • If you had a numeric range filter, and clear it from the snack bar, the UI in the sidebar doesn't update: It still shows a range being selected.
  • http://localhost:5001/test-search/donors?sort=bad: No results, and then the url updates to ?size=18... I think what I worry about here is the url update clobbering the original, bad, url that got us here.
  • Should the size be in the URL at all?
  • Conversely, tile mode is current captured in the URL, but it's not in the new search.

I don't think any of these should block this PR, but I wanted to note the behavior on the branch where I observed it.

Comment on lines 35 to 36
if (error.name === 'AbortError') {
// Aborting throws an error and will prevent state from being updated.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if (error.name === 'AbortError') {
// Aborting throws an error and will prevent state from being updated.
if (error.name !== 'AbortError') {
// Aborting throws an error and will prevent state from being updated.
// Other errors should still be thrown
throw error;

I'm not sure about the bigger picture, but right now it's a no-op.

@john-conroy
Copy link
Collaborator Author

Thanks. I should have been more clear, this wasn't meant to be a cure-all for the URL synchronization, but a fix for the specific bug described in the issue which was blocking other progress.

@john-conroy john-conroy merged commit fe4083d into main Sep 22, 2022
@john-conroy john-conroy deleted the john-conroy/fix-url-sync branch September 22, 2022 16:00
ilan-gold pushed a commit that referenced this pull request Oct 3, 2022
* Mccalluc/dev search warning (#2915)

* Add infobox to devsearch

* changelog

* Reenable WS deletion (#2914)

* Add link to menu (#2913)

* Mccalluc/fix services (#2917)

* update the service table

* changelog

* John conroy/preserve cells order (#2911)

* Use order from cells service

* Add test

* Add changelog

Co-authored-by: John Conroy <john-conroy@users.noreply.github.com>

* Mccalluc/marker gene to marker (#2920)

* Fix kwarg... but vis still not working?

* upgrade portal-visualization; rebuild requirements

* John conroy/fix url sync (#2909)

* Update redeploy script

* Add changelog

* Fix race condition in useSearchkitSDK

* Use abort controller

* Add changelog

* Console error if not abort error

Co-authored-by: John Conroy <john-conroy@users.noreply.github.com>

* John conroy/rotate chart labels (#2912)

* Pull longest label measurement to hook

* Adjust bottom margin based on longest x axis tick label

* Fix x scale band in dataset cluster chart

* Rotate axis tick labels

* Remove unused state from chart tooltip hook

* Add tick label tooltip

* Refactor tooltip

* Trim tick label strings

* Add offset for rotated histogram labels

* Add changelog

* Update histogram margin

* Update context/app/static/js/shared-styles/charts/utils.js

Co-authored-by: Chuck McCallum <mccalluc@users.noreply.github.com>

* Pull grid rows and group to component

* Use grid rows group in vertical bar chart and histogram

* Pull shared vertical chart hooks into single hook

Co-authored-by: John Conroy <john-conroy@users.noreply.github.com>
Co-authored-by: Chuck McCallum <mccalluc@users.noreply.github.com>

* John conroy/sort cells charts by value (#2918)

* Pull longest label measurement to hook

* Adjust bottom margin based on longest x axis tick label

* Fix x scale band in dataset cluster chart

* Rotate axis tick labels

* Remove unused state from chart tooltip hook

* Add tick label tooltip

* Refactor tooltip

* Trim tick label strings

* Add offset for rotated histogram labels

* Add changelog

* Update histogram margin

* Sort cluster chart on x axis by values

* Add changelog

* Use helper func per code suggestion

* Add test

Co-authored-by: John Conroy <john-conroy@users.noreply.github.com>

* Version bump to v0.53.2

* Update CHANGELOG

* Update typeservice to V3 (#2924)

* revert config changes: do not rely on anything outside

* Add type service to status page

* TYPE_SERVICE_PATH

* update comment and changelog

* python-linting

* Formerly, the type service was not exposed on the front end... now that it is on the service page, we need a placeholder value

* version index for ccf (#2927)

* Limit organ-info datasets to HRA-mapped HuBMAP data only (#2930)

* Limit organ-info datasets to HRA-mapped HuBMAP data only

* Create CHANGELOG-organ-info-data.md

* linewrap

* Bump CCF-UI organ-info version to 3.5.0

Co-authored-by: mccalluc <mccalluc@users.noreply.github.com>

* Make "citing HuBMAP" an outbound link (#2931)

Co-authored-by: John Conroy <62477388+john-conroy@users.noreply.github.com>
Co-authored-by: John Conroy <john-conroy@users.noreply.github.com>
Co-authored-by: Bruce W. Herr II <bherr@indiana.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Updated search route to state sometimes does not work
2 participants