John conroy/rotate chart labels #2912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mccalluc
reviewed
Sep 21, 2022
context/app/static/js/shared-styles/charts/VerticalStackedBarChart/VerticalStackedBarChart.jsx
Outdated
Show resolved
Hide resolved
context/app/static/js/shared-styles/charts/VerticalStackedBarChart/VerticalStackedBarChart.jsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Chuck McCallum <mccalluc@users.noreply.github.com>
ilan-gold
pushed a commit
that referenced
this pull request
Oct 3, 2022
* Mccalluc/dev search warning (#2915) * Add infobox to devsearch * changelog * Reenable WS deletion (#2914) * Add link to menu (#2913) * Mccalluc/fix services (#2917) * update the service table * changelog * John conroy/preserve cells order (#2911) * Use order from cells service * Add test * Add changelog Co-authored-by: John Conroy <john-conroy@users.noreply.github.com> * Mccalluc/marker gene to marker (#2920) * Fix kwarg... but vis still not working? * upgrade portal-visualization; rebuild requirements * John conroy/fix url sync (#2909) * Update redeploy script * Add changelog * Fix race condition in useSearchkitSDK * Use abort controller * Add changelog * Console error if not abort error Co-authored-by: John Conroy <john-conroy@users.noreply.github.com> * John conroy/rotate chart labels (#2912) * Pull longest label measurement to hook * Adjust bottom margin based on longest x axis tick label * Fix x scale band in dataset cluster chart * Rotate axis tick labels * Remove unused state from chart tooltip hook * Add tick label tooltip * Refactor tooltip * Trim tick label strings * Add offset for rotated histogram labels * Add changelog * Update histogram margin * Update context/app/static/js/shared-styles/charts/utils.js Co-authored-by: Chuck McCallum <mccalluc@users.noreply.github.com> * Pull grid rows and group to component * Use grid rows group in vertical bar chart and histogram * Pull shared vertical chart hooks into single hook Co-authored-by: John Conroy <john-conroy@users.noreply.github.com> Co-authored-by: Chuck McCallum <mccalluc@users.noreply.github.com> * John conroy/sort cells charts by value (#2918) * Pull longest label measurement to hook * Adjust bottom margin based on longest x axis tick label * Fix x scale band in dataset cluster chart * Rotate axis tick labels * Remove unused state from chart tooltip hook * Add tick label tooltip * Refactor tooltip * Trim tick label strings * Add offset for rotated histogram labels * Add changelog * Update histogram margin * Sort cluster chart on x axis by values * Add changelog * Use helper func per code suggestion * Add test Co-authored-by: John Conroy <john-conroy@users.noreply.github.com> * Version bump to v0.53.2 * Update CHANGELOG * Update typeservice to V3 (#2924) * revert config changes: do not rely on anything outside * Add type service to status page * TYPE_SERVICE_PATH * update comment and changelog * python-linting * Formerly, the type service was not exposed on the front end... now that it is on the service page, we need a placeholder value * version index for ccf (#2927) * Limit organ-info datasets to HRA-mapped HuBMAP data only (#2930) * Limit organ-info datasets to HRA-mapped HuBMAP data only * Create CHANGELOG-organ-info-data.md * linewrap * Bump CCF-UI organ-info version to 3.5.0 Co-authored-by: mccalluc <mccalluc@users.noreply.github.com> * Make "citing HuBMAP" an outbound link (#2931) Co-authored-by: John Conroy <62477388+john-conroy@users.noreply.github.com> Co-authored-by: John Conroy <john-conroy@users.noreply.github.com> Co-authored-by: Bruce W. Herr II <bherr@indiana.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #2593. There's some refactoring of common chart components/props that could be done, but I'd like to revisit.
Also adds tooltips for the x axis tick labels.